feat: Adjustments to Generic Business Partner model #479
Conversation
- optional BPN fields for input - bpnL/S/A naming - fixed assigment for isOwner, addressType
martinfkaeser
force-pushed
the
feat/gbpm_dto_model_adjustment
branch
from
394b5dd to
93f6df6
Compare
| bpns = entity.bpnS, | ||
| bpna = entity.bpnA ?: throw NullPointerException("bpnA is null"), | ||
| isOwner = entity.isOwner, | ||
| bpnL = entity.bpnL ?: throw NullPointerException("bpnL is null"), |
There was a problem hiding this comment.
Shouldn't we throw a Bpdm...Exception here?
There was a problem hiding this comment.
You mean like that:
throw BpdmNullMappingException(BusinessPartner::class, BusinessPartnerOutputDto::class, BusinessPartnerOutputDto::bpnL, entity.externalId)
| val shortName: String? | ||
|
|
||
| @get:ArraySchema(arraySchema = Schema(description = "The list of identifiers of the business partner.")) | ||
| @get:ArraySchema(arraySchema = Schema(description = "The list of identifiers of the business partner. Sorted and duplicates are removed.")) |
There was a problem hiding this comment.
This comment is used for request and response.
The request does not have to be sorted.
Duplicates are only removed in the request. The response should not contain any duplicate entries
There was a problem hiding this comment.
I tried to phrase it that it works for both the request and response.
But yes, it's not quite clear. What do you think about:
"Automatically sorted and duplicates removed."
Any other suggestions?
There was a problem hiding this comment.
Idea: "Sorted and duplicates removed by the service."
There was a problem hiding this comment.
I agree, sounds better to me
…ion & error handling
Small improvements to the DTO model:
Solves #384