Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add package-lock.json files #397

Merged
merged 1 commit into from
Mar 9, 2021
Merged

chore: add package-lock.json files #397

merged 1 commit into from
Mar 9, 2021

Conversation

danielpeintner
Copy link
Member

fixes #395
fixes #379

@danielpeintner
Copy link
Member Author

Note: adding package-lock.json might solve some issues but OPCUA tests are still very unstable because of other various reasons :-(

@danielpeintner
Copy link
Member Author

I had to re-run the GitHub action 3 times to make it succeed...
@relu91 @egekorkan shall we still merge the PR and take a look at the OPCUA issue if issues pop-up once again?

relu91
relu91 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. One comment:

adding package-lock.json might solve some issues but OPCUA tests are still very unstable because of other various reasons :-(

Which are those issues? random timeouts?

@danielpeintner
Copy link
Member Author

Which are those issues? random timeouts?

Yes, I think so.. always for OPCUA.
Unfortunately when clicking re-run the old log is gone

@danielpeintner danielpeintner merged commit 9d8abe1 into eclipse-thingweb:master Mar 9, 2021
@danielpeintner danielpeintner deleted the issue-395 branch November 15, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekorkan egekorkan egekorkan approved these changes

@relu91 relu91 relu91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OPCUA Issues Specify dependencies more precisely to avoid issues
3 participants
@danielpeintner @relu91 @egekorkan