Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify dependencies more precisely to avoid issues #379

Closed
danielpeintner opened this issue Jan 18, 2021 · 2 comments · Fixed by #397
Closed

Specify dependencies more precisely to avoid issues #379

danielpeintner opened this issue Jan 18, 2021 · 2 comments · Fixed by #397

Comments

@danielpeintner
Copy link
Member

see #378 (review)

@egekorkan
Copy link
Member

I like the comment #378 (review)

Another possibility would be to also push the lock files so that the environment that tests it has the exact version we need. It also enables dependabot or similar things to work

@relu91
Copy link
Member

relu91 commented Jan 22, 2021

Another possibility would be to also push the lock files so that the environment that tests it has the exact version we need. It also enables dependabot or similar things to work.

Right, I've just seen that the package-lock is ignored. Usually, it should be committed (see here). With this fix we don't need to specify the exact version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants