Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCUA Issues #395

Closed
danielpeintner opened this issue Mar 5, 2021 · 5 comments · Fixed by #397
Closed

OPCUA Issues #395

danielpeintner opened this issue Mar 5, 2021 · 5 comments · Fixed by #397

Comments

@danielpeintner
Copy link
Member

We seem to run into issues of OPCUA versioning.
see for example https://github.com/eclipse/thingweb.node-wot/pull/394/checks?check_run_id=2038479109

Error: node_modules/node-opcua-basic-types/dist/attributeIds.d.ts(34,33): error TS2694: Namespace '"fs"' has no exported member 'OpenMode'.

I assume this has to do with recent opcua updates and us having no "fixed" version in package.json.

Does anyone mind if I update to "fixed" versions e.g.,

  • "node-opcua": "^2.4.3" --> "node-opcua": "2.4.3"
  • "node-opcua-client": "^2.1.8" --> "node-opcua-client": "2.1.8"

@relu91 @egekorkan or do you think it is caused by other aspects?

@danielpeintner
Copy link
Member Author

related to #379

@danielpeintner
Copy link
Member Author

OR like @relu91 pointed out include package-lock.

Question. What do you prefer?

  • fix version OR
  • add package-lock

@egekorkan
Copy link
Member

I see it happening in other projects and that's why I like pushing lock files :)

@relu91
Copy link
Member

relu91 commented Mar 5, 2021

I'll add package-lock too. As another compelling evidence towards this decision, there's also the fact that neither .gitignore.io suggests ignoring package-lock.json files.

@mjkoster
Copy link

mjkoster commented Mar 5, 2021

I just ran into the same issue trying to build. I can wait until the issue is resolved, or if it will be a while I could work around, since I don't use OPC UA at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants