GH-7772: Fixed issue with filtered group options.

[kittaakos]

What it does

Fixes an issue with filtered group options. If a QuickOpenGroupItemOptions is filtered out, we merge the group properties into the next non-filtered item.

• Exposed the options from the QuickOpenItem.
• Made MonacoQuickOpenService#toOpenModel extensiable.

Closes #7772

How to test

Use the sample, search for A (make sure B is not among the search results), you can still see the Rest label and the border for the group.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

I tested the sample and it works well.
I however noticed a bug with the quick file open, it does not open and throws an error:

Uncaught (in promise) TypeError: handler.getOptions is not a function
    at PrefixQuickOpenService.<anonymous> (prefix-quick-open-service.ts:185)
    at step (prefix-quick-open-service.ts:15)
    at Object.next (prefix-quick-open-service.ts:15)
    at prefix-quick-open-service.ts:15
    at new Promise (<anonymous>)
    at ../../packages/core/lib/browser/quick-open/prefix-quick-open-service.js.__awaiter (prefix-quick-open-service.ts:15)
    at PrefixQuickOpenService.../../packages/core/lib/browser/quick-open/prefix-quick-open-service.js.PrefixQuickOpenService.setCurrentHandler (prefix-quick-open-service.ts:162)
    at PrefixQuickOpenService.../../packages/core/lib/browser/quick-open/prefix-quick-open-service.js.PrefixQuickOpenService.open (prefix-quick-open-service.ts:156)
    at QuickFileOpenService.push.../../packages/file-search/lib/browser/quick-file-open.js.QuickFileOpenService.open (quick-file-open.ts:124)
    at Object.execute (quick-file-open-contribution.ts:40)

[kittaakos]

I however noticed a bug with the quick file open, it does not open and throws an error:

I see, thanks for the heads-up. 👍 It is unrelated to the PR itself and the sample will be dropped anyway but I have added a fix in f0e9394; it works now. I'm going to leave this PR open until tomorrow, then merge it.

[spoenemann]

Looks good!

[akosyakov]

i am not sure that exposing this is a good idea. Someone can subclass QuickOpenItem and override methods to provide other values. We should rather call methods to collect computed values.

[kittaakos]

i am not sure that exposing this is a good idea.

Why? Please explain.

Someone can subclass QuickOpenItem and override methods to provide other values.

Yes, someone can do that, but I needed the original options do be able to create a "copy".

We should rather call methods to collect computed values.

I do not need computed values here.

[kittaakos]

Thank you all for the review. As I see the Windows CI has failed with a Git test error; I have opened a follow-up: #8023

I am going to drop the example and start a new build 🤞

[akosyakov]

what if item is a subclass of QuickOpenItem? Maybe we have QuickOpenGroupItem which is implemented by delegating to QuickOpenItem?

[kittaakos]

I do not understand it. Do you have an example in mind?

[akosyakov]

Look for extends QuickOpenItem, for instance here:

theia/packages/scm/src/browser/scm-quick-open-service.ts

Lines 73 to 100 in db8c807

	class ScmQuickOpenItem<T> extends QuickOpenItem {
	constructor(
	public readonly ref: T,
	protected readonly execute: (item: ScmQuickOpenItem<T>) => void,
	private readonly toLabel: (item: ScmQuickOpenItem<T>) => string = () => `${ref}`,
	private readonly toDescription: (item: ScmQuickOpenItem<T>) => string | undefined = () => undefined) {
	super();
	}
	run(mode: QuickOpenMode): boolean {
	if (mode !== QuickOpenMode.OPEN) {
	return false;
	}
	this.execute(this);
	return true;
	}
	getLabel(): string {
	return this.toLabel(this);
	}
	getDescription(): string | undefined {
	return this.toDescription(this);
	}
	}

Copying internal options won't provide proper label and description.

[kittaakos]

Closing in favor of #8024

[kittaakos]

@akosyakov, please check the other PR instead. Thank you!