Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed toOpenModel as an API method. #8024

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Exposed toOpenModel as an API method. #8024

merged 1 commit into from
Jun 17, 2020

Conversation

kittaakos
Copy link
Contributor

Signed-off-by: Akos Kitta [email protected]

What it does

Changes the visibility of the toOpenModel from private to protected.

How to test

Review checklist

Reminder for reviewers

@kittaakos kittaakos requested a review from akosyakov June 16, 2020 14:35
@kittaakos kittaakos mentioned this pull request Jun 16, 2020
Closed
1 task
@akosyakov akosyakov added quick-open issues related to the quick-open extensibility issues to simplify ability to extend Theia labels Jun 17, 2020
akosyakov
akosyakov approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kittaakos
Copy link
Contributor Author

The CI failure on Windows is unrelated, I guess. (#8023)

@kittaakos kittaakos merged commit d9541ce into master Jun 17, 2020
@kittaakos kittaakos deleted the expose-monaco-quick-open-api branch June 17, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
extensibility issues to simplify ability to extend Theia quick-open issues related to the quick-open
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @akosyakov