Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quick-open] Quick open groups are ignored when filtering with fuzzy label #7772

Open
kittaakos opened this issue May 7, 2020 · 0 comments
Open

[quick-open] Quick open groups are ignored when filtering with fuzzy label #7772

kittaakos opened this issue May 7, 2020 · 0 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco quick-open issues related to the quick-open

Comments

@kittaakos
Copy link
Contributor

Bug Description:

If I build an array of quick open items with groups (including borders and labels) and let monaco filter the items with fuzzyMatchLabel: { enableSeparateSubstringMatching: true }, then group items might get filtered out and breaks the group logic.

screencast 2020-05-07 15-48-10

Steps to Reproduce:

  1. https://github.com/eclipse-theia/theia/compare/quick-open-groups

Additional Information

  • Operating System:
  • Theia Version:
@kittaakos kittaakos self-assigned this May 7, 2020
@kittaakos kittaakos changed the title [quick-open] Quick open groups are ignored when filtering with with fuzzy label [quick-open] Quick open groups are ignored when filtering with fuzzy label May 7, 2020
@akosyakov akosyakov added monaco issues related to monaco quick-open issues related to the quick-open labels May 7, 2020
kittaakos pushed a commit that referenced this issue Jun 15, 2020
GH-7772: Fixed issue with filtered group options.
b15e80f 
If a `QuickOpenGroupItemOptions` is filtered out, we merge the group
properties into the next non-filtered item.

 - Exposed the `options` from the `QuickOpenItem`.
 - Made `MonacoQuickOpenService#toOpenModel` extensiable.

 Closes #7772

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Jun 15, 2020
Closed
1 task
kittaakos pushed a commit that referenced this issue Jun 15, 2020
GH-7772: Fixed issue with filtered group options.
64972ad 
If a `QuickOpenGroupItemOptions` is filtered out, we merge the group
properties into the next non-filtered item.

 - Exposed the `options` from the `QuickOpenItem`.
 - Made `MonacoQuickOpenService#toOpenModel` extensiable.

 Closes #7772

Signed-off-by: Akos Kitta <[email protected]>
@akosyakov akosyakov added the bug bugs found in the application label Jun 16, 2020
@kittaakos kittaakos removed their assignment Jun 16, 2020
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco quick-open issues related to the quick-open
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-7772: Fixed issue with filtered group options. eclipse-theia/theia
2 participants
@kittaakos @akosyakov