[mini-browser] support '.xhtml' file for preview #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Oops, sorry for the late review, I missed the notification.
Approved! Works as advertised, many thanks.
I also tried to find realistic edge-cases for files ending with *html where you don't want to reset the mini-browser background, but I didn't find any (only false positives I could think of are directories ending with html, or binaries called something2html, but we don't open these in mini-browsers anyway).
vince-fugnitto
added a commit
that referenced
this pull request
Feb 3, 2020
Fixes #6969 With this change, `.xhtml` files can now be successfully previewed similarly to `.html` files. The method `resetBackground` has also been updated with a minor change to also support resetting the background for `.xhtml` files. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/GH-6968
branch
from
f4d0427 to
8d09d16
Compare
vince-fugnitto
added a commit
that referenced
this pull request
Feb 3, 2020
Fixes #6969 This change allows previewing multiple different file types from the `HtmlHandler` endpoint. The supported file types include: - `.html` (previously supported) - `.xhtml` (newly supported) - `.htm` (newly supported) The resetBackground method has also been updated to support the new file types. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/GH-6968
branch
from
8d09d16 to
d96b879
Compare
jankeromnes
approved these changes
Feb 4, 2020
vince-fugnitto
added a commit
that referenced
this pull request
Feb 4, 2020
Fixes #6969 This change allows previewing multiple different file types from the `HtmlHandler` endpoint. The supported file types include: - `.html` (previously supported) - `.xhtml` (newly supported) - `.htm` (newly supported) The resetBackground method has also been updated to support the new file types. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/GH-6968
branch
from
d96b879 to
b98aa8a
Compare
jankeromnes
approved these changes
Feb 4, 2020
Every release I usually go over all changes during a month and create entries for fixes, new features, and breaking changes if I find any :) #7014 |
Fixes #6969 This change allows previewing multiple different file types from the `HtmlHandler` endpoint. The supported file types include: - `.html` (previously supported) - `.xhtml` (newly supported) - `.htm` (newly supported) The resetBackground method has also been updated to support the new file types. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/GH-6968
branch
from
b98aa8a to
d1bb884
Compare
akosyakov
pushed a commit
to akosyakov/theia
that referenced
this pull request
Feb 24, 2020
Fixes eclipse-theia#6969 This change allows previewing multiple different file types from the `HtmlHandler` endpoint. The supported file types include: - `.html` (previously supported) - `.xhtml` (newly supported) - `.htm` (newly supported) The resetBackground method has also been updated to support the new file types. Signed-off-by: Vincent Fugnitto <[email protected]>
JesterOrNot
pushed a commit
to JesterOrNot/theia
that referenced
this pull request
Mar 12, 2020
Fixes eclipse-theia#6969 This change allows previewing multiple different file types from the `HtmlHandler` endpoint. The supported file types include: - `.html` (previously supported) - `.xhtml` (newly supported) - `.htm` (newly supported) The resetBackground method has also been updated to support the new file types. Signed-off-by: Vincent Fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6968
The pull-request adds support to display
.xhtmlfiles as a preview using themini-browser.resetBackgroundto also accept resetting backgrounds for.xhtmlfiles.How to test
.htmlfile (verify that preview works using the toolbar item).xhtmlfile (verify that the preview works using the toolbar item).htmfile (verify that the preview works using the toolbar item)Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]