Revert "Lazily update frames of all threads in all-stop mode" #7272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @marechal-p @akosyakov |
This reverts commit d1678ad. Fixes #7272 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
revert-6869-update-frame-upstream
branch
from
4354693 to
ca299fb
Compare
|
Merging as per #7264 (comment) |
lmcbout
pushed a commit
that referenced
this pull request
Mar 4, 2020
This reverts commit d1678ad. Fixes #7272 Signed-off-by: Marc Dumais <[email protected]>
Closed
JesterOrNot
pushed a commit
to JesterOrNot/theia
that referenced
this pull request
Mar 12, 2020
This reverts commit d1678ad. Fixes eclipse-theia#7272 Signed-off-by: Marc Dumais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6869 because of this regression #7264
We're still looking for a fix that would avoid reverting #6969 - please do not merge this PR yet.