[mini-browser] add additional 'HtmlHandler' files

Fixes #6969 This change allows previewing multiple different file types from the `HtmlHandler` endpoint. The supported file types include: - `.html` (previously supported) - `.xhtml` (newly supported) - `.htm` (newly supported) The resetBackground method has also been updated to support the new file types. Signed-off-by: Vincent Fugnitto <[email protected]>
eclipse-theia · Feb 5, 2020 · d1bb884 · d1bb884
1 parent 8deef2a
commit d1bb884
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/mini-browser/src/browser/mini-browser-open-handler.ts b/packages/mini-browser/src/browser/mini-browser-open-handler.ts
@@ -159,7 +159,12 @@ export class MiniBrowserOpenHandler extends NavigatableWidgetOpenHandler<MiniBro
 
     protected resetBackground(uri: URI): MaybePromise<boolean> {
         const { scheme } = uri;
-        return scheme === 'http' || scheme === 'https' || (scheme === 'file' && uri.toString().endsWith('.html'));
+        const uriStr = uri.toString();
+        return scheme === 'http'
+            || scheme === 'https'
+            || (scheme === 'file'
+                && (uriStr.endsWith('html') || uriStr.endsWith('.htm'))
+            );
     }
 
     protected async defaultOptions(): Promise<MiniBrowserOpenerOptions & { widgetOptions: ApplicationShell.WidgetOptions }> {

diff --git a/packages/mini-browser/src/node/mini-browser-endpoint.ts b/packages/mini-browser/src/node/mini-browser-endpoint.ts
@@ -198,8 +198,8 @@ const CODE_EDITOR_PRIORITY = 100;
 @injectable()
 export class HtmlHandler implements MiniBrowserEndpointHandler {
 
-    supportedExtensions(): string {
-        return 'html';
+    supportedExtensions(): string[] {
+        return ['html', 'xhtml', 'htm'];
     }
 
     priority(): number {