-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bunyan] remove '@theia/bunyan' extension #6651
Conversation
I also noticed the dependency
theia/packages/core/package.json Line 13 in 87df21b
|
1893839
to
aaa12fa
Compare
@marcdumais-work I added an extra commit which takes care of removing the |
Looking good - with the latest version, the only gitpod /workspace/theia $ grep -R -i bunyan * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should probably wait at least a day before merging, to give community members time to potentially object.
Sounds good! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to remove unused stuff :)
Maybe announce on Spectrum, just to make sure. But we can always reincarnate it as a separate repo if there anyone eager to maintain it. |
f0ee034
to
f6ec01a
Compare
I created a post on Spectrum as well so its more visible to the community: https://spectrum.chat/theia/general/the-theia-bunyan-extension-to-be-removed~811cbba0-6977-449b-b7b0-ac5fb25b9231 |
Fixes #6637 Motivation: - the extension is not used by any other extension present in the main repo. - the extension is not part of the `example-browser` or `example-electron` application, therefore it cannot be tested properly. - since it is not part of any other extension, or tested, it is likely to be un-maintained. Signed-off-by: vince-fugnitto <[email protected]>
- removes the `bunyan` dependency which is unused. - removes the `@types/bunyan` dependency which is unused. Signed-off-by: vince-fugnitto <[email protected]>
f6ec01a
to
ad3bdb8
Compare
I'll give others a chance to view the PR if they'd like and merge on Monday. |
What it does
Fixes #6637
Motivation:
example-browser
orexample-electron
application, therefore it cannot be tested properly.How to test
@theia/bunyan
dependencies were present, building the project and ensuring that tests successfully passed when removed.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]