Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] why is '@theia/bunyan' part of the main repository #6637

Closed
vince-fugnitto opened this issue Nov 26, 2019 · 8 comments · Fixed by #6651
Closed

[question] why is '@theia/bunyan' part of the main repository #6637

vince-fugnitto opened this issue Nov 26, 2019 · 8 comments · Fixed by #6651
Labels
logging issues related to logging question user / developer questions

Comments

@vince-fugnitto
Copy link
Member

Description

I have a question regarding the @theia/bunyan extension present in the main repository.
It looks like there are no extensions (part of the main repo) that depend or use the extension, and it is not included in the example-browser or example-electron applications. It also does not seem to be updated frequently. Is it a source for clean-up, or is there a reason it is present in the main repo?

@vince-fugnitto vince-fugnitto added question user / developer questions logging issues related to logging labels Nov 26, 2019
@akosyakov
Copy link
Member

Initially we though to use it as a primary logger, but after gaining some experience with end products it becomes clear that using console by default is better. So it is kind of an additional implementation of logging. I'm not sure whether anyone is using it @eclipse-theia/ecd-theia-committers ? If not pulling it out of repo or removing would be fine to make our build faster.

@thegecko
Copy link
Member

Happy to have it removed

@westbury
Copy link
Contributor

Mbed Studio uses log4js, implemented in its own extension based on @theia/bunyan. So it might be useful to keep in another repo somewhere as an example for those who want file logging.

@marcdumais-work
Copy link
Contributor

Mbed Studio uses log4js, implemented in its own extension based on @theia/bunyan.

Is your extension a standalone implementation based-on or inspired from @theia/bunyan or does it depend-on / extend it?

So it might be useful to keep in another repo somewhere as an example for those who want file logging.

We can easily create a new project under theia-ide/ and move it there, but it will be of limited long-term usefulness unless it's maintained/used. Is there interest from someone in taking ownership of this, maybe also adding an example application that uses it, CI, etc?

@vince-fugnitto
Copy link
Member Author

Mbed Studio uses log4js, implemented in its own extension based on @theia/bunyan.

Is your extension a standalone implementation based-on or inspired from @theia/bunyan or does it depend-on / extend it?

I think it might simply be inspired by, and that the suggestion was to have it as an example, but I'm not sure the effort in maintaining it is worthwhile. At the moment since it is not even used, we don't know if it is actually working correctly or not.

So it might be useful to keep in another repo somewhere as an example for those who want file logging.

We can easily create a new project under theia-ide/ and move it there, but it will be of limited long-term usefulness unless it's maintained/used. Is there interest from someone in taking ownership of this, maybe also adding an example application that uses it, CI, etc?

Perhaps if we just want it as an example of file based logging we can simply create a repo and name it as an {name}-example? There might not be a need for CI but just have it for educational purposes.

@westbury
Copy link
Contributor

Is your extension a standalone implementation based-on or inspired from @theia/bunyan or does it depend-on / extend it?

Yes, I meant 'Inspired by'. Sorry to be confusing.

@marcdumais-work
Copy link
Contributor

Perhaps if we just want it as an example of file based logging we can simply create a repo and name it as an {name}-example? There might not be a need for CI but just have it for educational purposes.

I vote to remove it unless someone will put some effort to maintain it as a working example. We probably do not even know if it still works. If it's needed later, it will still exist in the project's git history.

@vince-fugnitto
Copy link
Member Author

Perhaps if we just want it as an example of file based logging we can simply create a repo and name it as an {name}-example? There might not be a need for CI but just have it for educational purposes.

I vote to remove it unless someone will put some effort to maintain it as a working example. We probably do not even know if it still works. If it's needed later, it will still exist in the project's git history.

+1 I'll create a PR which removes it

vince-fugnitto added a commit that referenced this issue Nov 27, 2019
Fixes #6637

Motivation:
- the extension is not used by any other extension present in the main repo.
- the extension is not part of the `example-browser` or `example-electron`
application, therefore it cannot be tested properly.
- since it is not part of any other extension, or tested, it is likely
to be un-maintained.

Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Nov 27, 2019
Fixes #6637

Motivation:
- the extension is not used by any other extension present in the main repo.
- the extension is not part of the `example-browser` or `example-electron`
application, therefore it cannot be tested properly.
- since it is not part of any other extension, or tested, it is likely
to be un-maintained.

Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Nov 28, 2019
Fixes #6637

Motivation:
- the extension is not used by any other extension present in the main repo.
- the extension is not part of the `example-browser` or `example-electron`
application, therefore it cannot be tested properly.
- since it is not part of any other extension, or tested, it is likely
to be un-maintained.

Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Nov 28, 2019
Fixes #6637

Motivation:
- the extension is not used by any other extension present in the main repo.
- the extension is not part of the `example-browser` or `example-electron`
application, therefore it cannot be tested properly.
- since it is not part of any other extension, or tested, it is likely
to be un-maintained.

Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Dec 2, 2019
Fixes #6637

Motivation:
- the extension is not used by any other extension present in the main repo.
- the extension is not part of the `example-browser` or `example-electron`
application, therefore it cannot be tested properly.
- since it is not part of any other extension, or tested, it is likely
to be un-maintained.

Signed-off-by: vince-fugnitto <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Fixes eclipse-theia#6637

Motivation:
- the extension is not used by any other extension present in the main repo.
- the extension is not part of the `example-browser` or `example-electron`
application, therefore it cannot be tested properly.
- since it is not part of any other extension, or tested, it is likely
to be un-maintained.

Signed-off-by: vince-fugnitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging issues related to logging question user / developer questions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants