-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question] why is '@theia/bunyan' part of the main repository #6637
Comments
Initially we though to use it as a primary logger, but after gaining some experience with end products it becomes clear that using console by default is better. So it is kind of an additional implementation of logging. I'm not sure whether anyone is using it @eclipse-theia/ecd-theia-committers ? If not pulling it out of repo or removing would be fine to make our build faster. |
Happy to have it removed |
Mbed Studio uses log4js, implemented in its own extension based on @theia/bunyan. So it might be useful to keep in another repo somewhere as an example for those who want file logging. |
Is your extension a standalone implementation based-on or inspired from
We can easily create a new project under |
I think it might simply be inspired by, and that the suggestion was to have it as an example, but I'm not sure the effort in maintaining it is worthwhile. At the moment since it is not even used, we don't know if it is actually working correctly or not.
Perhaps if we just want it as an example of file based logging we can simply create a repo and name it as an |
Yes, I meant 'Inspired by'. Sorry to be confusing. |
I vote to remove it unless someone will put some effort to maintain it as a working example. We probably do not even know if it still works. If it's needed later, it will still exist in the project's git history. |
+1 I'll create a PR which removes it |
Fixes #6637 Motivation: - the extension is not used by any other extension present in the main repo. - the extension is not part of the `example-browser` or `example-electron` application, therefore it cannot be tested properly. - since it is not part of any other extension, or tested, it is likely to be un-maintained. Signed-off-by: vince-fugnitto <[email protected]>
Fixes #6637 Motivation: - the extension is not used by any other extension present in the main repo. - the extension is not part of the `example-browser` or `example-electron` application, therefore it cannot be tested properly. - since it is not part of any other extension, or tested, it is likely to be un-maintained. Signed-off-by: vince-fugnitto <[email protected]>
Fixes #6637 Motivation: - the extension is not used by any other extension present in the main repo. - the extension is not part of the `example-browser` or `example-electron` application, therefore it cannot be tested properly. - since it is not part of any other extension, or tested, it is likely to be un-maintained. Signed-off-by: vince-fugnitto <[email protected]>
Fixes #6637 Motivation: - the extension is not used by any other extension present in the main repo. - the extension is not part of the `example-browser` or `example-electron` application, therefore it cannot be tested properly. - since it is not part of any other extension, or tested, it is likely to be un-maintained. Signed-off-by: vince-fugnitto <[email protected]>
Fixes #6637 Motivation: - the extension is not used by any other extension present in the main repo. - the extension is not part of the `example-browser` or `example-electron` application, therefore it cannot be tested properly. - since it is not part of any other extension, or tested, it is likely to be un-maintained. Signed-off-by: vince-fugnitto <[email protected]>
Fixes eclipse-theia#6637 Motivation: - the extension is not used by any other extension present in the main repo. - the extension is not part of the `example-browser` or `example-electron` application, therefore it cannot be tested properly. - since it is not part of any other extension, or tested, it is likely to be un-maintained. Signed-off-by: vince-fugnitto <[email protected]>
Description
I have a question regarding the
@theia/bunyan
extension present in the main repository.It looks like there are no extensions (part of the main repo) that depend or use the extension, and it is not included in the
example-browser
orexample-electron
applications. It also does not seem to be updated frequently. Is it a source for clean-up, or is there a reason it is present in the main repo?The text was updated successfully, but these errors were encountered: