Skip to content

Commit

Permalink
Remove '@theia/bunyan' extension
Browse files Browse the repository at this point in the history
Fixes #6637

Motivation:
- the extension is not used by any other extension present in the main repo.
- the extension is not part of the `example-browser` or `example-electron`
application, therefore it cannot be tested properly.
- since it is not part of any other extension, or tested, it is likely
to be un-maintained.

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto committed Nov 27, 2019
1 parent 87df21b commit aaa12fa
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 337 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ cache:
- examples/browser/node_modules
- examples/electron/node_modules
- node_modules
- packages/bunyan/node_modules
- packages/callhierarchy/node_modules
- packages/console/node_modules
- packages/core/node_modules
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Breaking changes:
allowing them to break out and manipulate shared data as cookies, local storage or even start service workers
for the main window as well as for each other. Now each webview will be deployed on own origin by default.
- Webview origin pattern can be configured with `THEIA_WEBVIEW_EXTERNAL_ENDPOINT` env variable. The default value is `{{uuid}}.webview.{{hostname}}`.
Here `{{uuid}}` and `{{hostname}}` are placeholders which get replaced at runtime with proper webview uuid
Here `{{uuid}}` and `{{hostname}}` are placeholders which get replaced at runtime with proper webview uuid
and [hostname](https://developer.mozilla.org/en-US/docs/Web/API/HTMLHyperlinkElementUtils/hostname) correspondingly.
- To switch to unsecure mode as before configure `THEIA_WEBVIEW_EXTERNAL_ENDPOINT` with `{{hostname}}` as a value.
You can also drop `{{uuid}}.` prefix, in this case, webviews still will be able to access each other but not the main window.
Expand All @@ -34,6 +34,7 @@ Breaking changes:
Most browsers define a page as served from secure context if its url has `https` scheme. For local testing `localhost` is treated as a secure context as well.
Unfortunately, it does not work nicely in FireFox, since it does not treat subdomains of localhost as secure as well, compare to Chrome.
If you want to test with FireFox you can configure it as described [here](https://github.com/eclipse-theia/theia/pull/6465#issuecomment-556443218).
- [bunyan] removed [`@theia/bunyan`](https://github.com/eclipse-theia/theia/tree/b92a5673de1e9d1bdc85e6200486b92394200579/packages/bunyan) extension [#6651](https://github.com/eclipse-theia/theia/pull/6651)

## v0.12.0

Expand Down
9 changes: 0 additions & 9 deletions packages/bunyan/README.md

This file was deleted.

11 changes: 0 additions & 11 deletions packages/bunyan/compile.tsconfig.json

This file was deleted.

47 changes: 0 additions & 47 deletions packages/bunyan/package.json

This file was deleted.

23 changes: 0 additions & 23 deletions packages/bunyan/src/node/bunyan-backend-module.ts

This file was deleted.

221 changes: 0 additions & 221 deletions packages/bunyan/src/node/bunyan-logger-server.ts

This file was deleted.

21 changes: 0 additions & 21 deletions packages/bunyan/src/package.spec.ts

This file was deleted.

3 changes: 0 additions & 3 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,6 @@
"@theia/editorconfig/lib/*": [
"packages/editorconfig/src/*"
],
"@theia/bunyan/lib/*": [
"packages/bunyan/src/*"
],
"@theia/console/lib/*": [
"packages/console/src/*"
],
Expand Down

0 comments on commit aaa12fa

Please sign in to comment.