Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the Open Source tab-bar toolbar for a preview, when it is available #5110

Closed
kittaakos opened this issue May 10, 2019 · 0 comments · Fixed by #10047
Closed

Show the Open Source tab-bar toolbar for a preview, when it is available #5110

kittaakos opened this issue May 10, 2019 · 0 comments · Fixed by #10047
Labels
preview issues related to the preview

Comments

@kittaakos
Copy link
Contributor

The Open Source tab-bar toolbar item is always visible even if the "source" cannot be opened. For instance, for images. Clicking on the Open Source does nothing, no errors either, because the "source" is already opened. There is no other way to open a JPG.

Screen Shot 2019-05-10 at 11 16 39

Steps to reproduce:

  • Open a JPG.
fangnx pushed a commit to fangnx/theia that referenced this issue May 21, 2019
fangnx pushed a commit to fangnx/theia that referenced this issue May 21, 2019
fangnx pushed a commit to fangnx/theia that referenced this issue May 21, 2019
fangnx pushed a commit to fangnx/theia that referenced this issue May 22, 2019
fangnx pushed a commit to fangnx/theia that referenced this issue May 23, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue May 23, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue May 23, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue May 27, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue May 27, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue May 28, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue May 29, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue May 29, 2019
…pen source" to work with image/pdf files

Signed-off-by: fangnx <[email protected]>
@vince-fugnitto vince-fugnitto added the preview issues related to the preview label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview issues related to the preview
Projects
None yet
2 participants