Fixed eclipse-theia#5110: made "open source" only visible when it is …

…available Signed-off-by: fangnx <[email protected]>
fangnx · May 21, 2019 · deccaa9 · deccaa9
1 parent f39185a
commit deccaa9
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/packages/mini-browser/src/browser/mini-browser-open-handler.ts b/packages/mini-browser/src/browser/mini-browser-open-handler.ts
@@ -167,6 +167,14 @@ export class MiniBrowserOpenHandler extends NavigatableWidgetOpenHandler<MiniBro
         };
     }
 
+    protected canOpenSource(widget: Widget): boolean {
+        const extension = widget.title.label.toString().split('.').pop();
+        if (extension) {
+            return ['jpg', 'jpeg', 'png', 'bmp', 'gif', 'pdf'].indexOf(extension.toLocaleLowerCase()) === -1;
+        }
+        return false;
+    }
+
     registerCommands(commands: CommandRegistry): void {
         commands.registerCommand(MiniBrowserCommands.PREVIEW, {
             execute: widget => this.preview(widget),
@@ -176,7 +184,7 @@ export class MiniBrowserOpenHandler extends NavigatableWidgetOpenHandler<MiniBro
         commands.registerCommand(MiniBrowserCommands.OPEN_SOURCE, {
             execute: widget => this.openSource(widget),
             isEnabled: widget => !!this.getSourceUri(widget),
-            isVisible: widget => !!this.getSourceUri(widget)
+            isVisible: widget => (!!this.getSourceUri(widget)) && this.canOpenSource(widget)
         });
         commands.registerCommand(MiniBrowserCommands.OPEN_URL, {
             execute: (arg?: string) => this.openUrl(arg)