mini-browser: fix source and preview #10047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Sep 4, 2021
|
This is working well for me, but I have one minor comment re: the open source behavior:
Perhaps that's outside the scope of this PR, but it was the main difference between our behavior and theirs that I could detect. |
vince-fugnitto
force-pushed
the
vf/mini-browser
branch
from
38ea553 to
bcb96b8
Compare
colin-grant-work
approved these changes
Sep 7, 2021
|
I'm still thinking of what the best behavior would be for the Resources such as:
Should likely have the sources as the primary or highest opener. |
vince-fugnitto
force-pushed
the
vf/mini-browser
branch
from
bcb96b8 to
4ece63e
Compare
|
The changes should be good now if anyone is interested in another round of review 👍 The change:
|
msujew
approved these changes
Sep 9, 2021
The commit fixes issues related to `preview` and `source` in the mini-browser extension. The change: - allows users to open the source of an image if they use the command, or toolbar item. - allows users to open the preview of an image's sources if they use the command or toolbar item. The fix should also apply to all supported extension types the mini-browser declares (svg, html,...). Signed-off-by: vince-fugnitto <[email protected]> Co-authored-by: fangx <[email protected]>
The commit aligns the behavior when opening the source of a previewed (rendered) markdown to open it as `tab-after` (aligning with the behavior present in vscode). Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/mini-browser
branch
from
4ece63e to
4e1501a
Compare
|
@colin-grant-work did you have any additional feedback for the pull-request? |
colin-grant-work
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #5110
Fixes: #5223
Closes: #5206
The change fixes the source and preview commands from the
mini-browserto use the proper opener.The change allows us to now successfully open the source of a preview, and vice-versa which was previously not possible (master).
The commit also aligns the behavior when opening the sources from a preview to open as tab-right instead of in a new editor group similarly to the behavior present in vscode.
How to test
open sourcetoolbar item successfully opens the file's sources (a dialog might appear)open previewtoolbar item opens the file's previewmini-browser-fix.mp4
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]
Co-authored-by: fangx [email protected]