Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JAVA_VERSION to JDK_VERSION mapping for Java12 #4645

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Add JAVA_VERSION to JDK_VERSION mapping for Java12 #4645

merged 1 commit into from
Feb 7, 2019

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Feb 7, 2019

Fixes: #4638
[ci skip]

Signed-off-by: lanxia [email protected]

@llxia
Copy link
Contributor Author

llxia commented Feb 7, 2019

Just a note, this temporary code as the following will be removed once we completely switch to
JDK_VERSION:

ifeq ($(JAVA_VERSION), SE80)
	JDK_VERSION:=8
endif
ifeq ($(JAVA_VERSION), SE90)
	JDK_VERSION:=9
endif
ifeq ($(JAVA_VERSION), SE100)
	JDK_VERSION:=10
endif
ifeq ($(JAVA_VERSION), SE110)
	JDK_VERSION:=11
endif
ifeq ($(JAVA_VERSION), SE120)
	JDK_VERSION:=12
endif

smlambert
smlambert approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @llxia and agree we should make a plan / set a date where we switch over... sometime not just before a big release ;)

smlambert
smlambert requested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright check...

@llxia llxia changed the title Add mapping for Java12 Add JAVA_VERSION to JDK_VERSION mapping for Java12 Feb 7, 2019
@llxia llxia added the comp:test label Feb 7, 2019
@llxia
Copy link
Contributor Author

llxia commented Feb 7, 2019

jenkins test sanity xlinux jdk11

@llxia
Copy link
Contributor Author

llxia commented Feb 7, 2019

Tested in Grinder for Java12: https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/254/consoleFull
DDR compilation passed. It failed in Java8andUp compilation as I do not apply PR #4531 in my branch.

@llxia llxia mentioned this pull request Feb 7, 2019
Closed
5 tasks
@smlambert
Copy link
Contributor

smlambert commented Feb 7, 2019 •
edited
Loading

I do not need to wait for jdk11 sanity run to complete, the test for this PR was that they would still compile and execute.

@smlambert smlambert merged commit a66c432 into eclipse-openj9:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llxia @smlambert