Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting JAVA_VERSION in testing #869

Closed
2 of 5 tasks
llxia opened this issue Feb 7, 2019 · 6 comments
Closed
2 of 5 tasks

Stop supporting JAVA_VERSION in testing #869

llxia opened this issue Feb 7, 2019 · 6 comments

Comments

@llxia
Copy link
Contributor

llxia commented Feb 7, 2019

Currently, we are supporting both JAVA_VERSION and JDK_VERSION as the parameter in the test Jenkins script and TKG. Initially, this was a temporary approach, as our ultimate goal is to completely switch to use JDK_VERSION. We should not keep maintaining the temporary code for JAVA_VERSION to JDK_VERSION mapping (eclipse-openj9/openj9#4645).

This issue is to remove supporting JAVA_VERSION completely.

ToDos:

  • Jenkinsfilebase needs to update to make sure JDK_VERSION works
  • Update test jobs and grinders to set JDK_VERSION in job configure and remove JAVA_VERSION (depends how the test job is invoked, this may not be a blocker)
  • Request upstream jobs to pass in JDK_VERSION if needed
  • Remove temporary code for JAVA_VERSION to JDK_VERSION mapping in Jenkinsfile and TKG
  • Update docs/wiki/readme accordingly
@llxia
Copy link
Contributor Author

llxia commented Feb 8, 2019

If auto detects JDK_VERSION, JDK_IMPL and SPEC are completed eclipse-openj9/openj9#442, then JDK_VERSION and JDK_IMPL are not needed in the regular test builds. However, Jenkinsfilebase still needs to be updated to accept JDK_VERSION. If the user chooses nightly in Grinder, JDK_VERSION and JDK_IMPL are still needed.

@keithc-ca
Copy link
Contributor

Shall we assume the references to JAVA_VESION are just typos that should say JAVA_VERSION?

@llxia
Copy link
Contributor Author

llxia commented Feb 8, 2019

yes, description is updated. Thanks

llxia added a commit to llxia/aqa-tests that referenced this issue Feb 8, 2019
- replace JAVA_VERSION by JDK_VERSION
- temporarily support JAVA_VERSION. If JAVA_VERSION is provided, map it
to JDK_VERSION
- update get.sh to consume JDK_VERSION

Issue: adoptium#869

Signed-off-by: lanxia <[email protected]>
llxia added a commit that referenced this issue Feb 12, 2019
- replace JAVA_VERSION by JDK_VERSION
- temporarily support JAVA_VERSION. If JAVA_VERSION is provided, map it
to JDK_VERSION
- update get.sh to consume JDK_VERSION

Issue: #869

Signed-off-by: lanxia <[email protected]>
@AdamBrousseau
Copy link
Contributor

AdamBrousseau commented Feb 12, 2019

Can this be blocked on #837? Otherwise I (we) will have to manually update a few hundred Jenkins jobs.
OpenJ9 pipelines do not pass JAVA_VERSION or JDK_VERSION, although they could, and if test pipelines ignore the former as the jobs set it by default.

@llxia
Copy link
Contributor Author

llxia commented Feb 12, 2019

I do not think this is necessarily blocked by #837. Although #837 is a good idea, I also would like to investigate if we could generate the job dynamically.

As you mentioned, upstream jobs could pass JDK_VERSION into test jobs. At the moment, the test script will check for JAVA_VERSION only if JDK_VERSION is not set. That is, if JDK_VERSION is passed in, we will take JDK_VERSION regardless JAVA_VERSION exists or not.
btw, with the completion of eclipse-openj9/openj9#442, test job does not need JDK_VERSION to be set.

@llxia
Copy link
Contributor Author

llxia commented Aug 8, 2019

Close this as it is a dup of #563

@llxia llxia closed this as completed Aug 8, 2019
@karianna karianna added this to the August 2019 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants