-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop supporting JAVA_VERSION in testing #869
Comments
If auto detects JDK_VERSION, JDK_IMPL and SPEC are completed eclipse-openj9/openj9#442, then |
Shall we assume the references to |
yes, description is updated. Thanks |
- replace JAVA_VERSION by JDK_VERSION - temporarily support JAVA_VERSION. If JAVA_VERSION is provided, map it to JDK_VERSION - update get.sh to consume JDK_VERSION Issue: adoptium#869 Signed-off-by: lanxia <[email protected]>
- replace JAVA_VERSION by JDK_VERSION - temporarily support JAVA_VERSION. If JAVA_VERSION is provided, map it to JDK_VERSION - update get.sh to consume JDK_VERSION Issue: #869 Signed-off-by: lanxia <[email protected]>
Can this be blocked on #837? Otherwise I (we) will have to manually update a few hundred Jenkins jobs. |
I do not think this is necessarily blocked by #837. Although #837 is a good idea, I also would like to investigate if we could generate the job dynamically. As you mentioned, upstream jobs could pass |
Close this as it is a dup of #563 |
Currently, we are supporting both
JAVA_VERSION
andJDK_VERSION
as the parameter in the test Jenkins script and TKG. Initially, this was a temporary approach, as our ultimate goal is to completely switch to useJDK_VERSION
. We should not keep maintaining the temporary code forJAVA_VERSION
toJDK_VERSION
mapping (eclipse-openj9/openj9#4645).This issue is to remove supporting
JAVA_VERSION
completely.ToDos:
JDK_VERSION
worksJDK_VERSION
in job configure and removeJAVA_VERSION
(depends how the test job is invoked, this may not be a blocker)JDK_VERSION
if neededJAVA_VERSION
toJDK_VERSION
mapping in Jenkinsfile and TKGThe text was updated successfully, but these errors were encountered: