Java 12 test compilation #4531
Java 12 test compilation #4531
Conversation
theresa-m
force-pushed
the
working_12_test
branch
3 times, most recently
from
25b6528 to
c2110af
Compare
| public <E extends Enum<E>> E[] getEnumConstantsShared(Class<E> clazz) { | ||
| return this.access.getEnumConstantsShared(clazz); | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this file src_120/src_110/org/openj9/test/jdk/internal/InternalAccessor.java the same as file above src_110/org/openj9/test/jdk/internal/InternalAccessor.java?
If two files are needed, it is needed to put 110 under 120? src_120/src_110/?
There was a problem hiding this comment.
The difference is in the imports.
Java 11:
import jdk.internal.misc.SharedSecrets; import jdk.internal.misc.JavaLangAccess;
Java 12:
import jdk.internal.access.SharedSecrets; import jdk.internal.access.JavaLangAccess;
These libraries were moved around in Java 12
There was a problem hiding this comment.
and clearly the file structure is a bit off here.. src_120/src_110 I'll fix that for sure
|
@llxia Does this change look OK now? I'd like to get to a jdk12 build up and running asap |
|
jdk12 testing in https://ci.eclipse.org/openj9/view/Pipelines/job/Pipeline-Release-Build/40/ with this change and #3980 shows only known issues. cmdLineTester_CryptoTest_0 - openssl not ported to jdk12 yet #4658 #4661 |
|
@theresa-m Could you rebase your branch so that #3980 is included? I would like to run PR builds for jdk11 and jdk12 if possible. |
In Java 12 internal libraries SharedSecrets and JavaLangAccess were moved from jdk.internal.misc to jdk.internal.access causing some tests in Java8AndUp to fail. To reuse as little code as possible I've moved all the tests that were in src_110 to a folder called src_110_up which will be used for versions 11+. I've wrapped the uses of SharedSecrets and JavaLangAccess into a class called InternalAccessor. There is one InternalAccessor for Java 11 in src_110 and one for Java 12 in src_120. Signed-off-by: Theresa Mammarella <[email protected]>
Causing FileNotFound exception Signed-off-by: Theresa Mammarella <[email protected]>
Signed-off-by: Theresa Mammarella <[email protected]>
Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
working_12_test
branch
from
1be27d2 to
11906b0
Compare
|
sure. @llxia rebase is done |
|
Jenkins test sanity xlinux jdk11 |
|
JDK12 PR build is not supported yet. |
Depends on Java 12 compilation pr: #3980
Fixes: #4522
In Java 12 internal libraries SharedSecrets and JavaLangAccess were moved from jdk.internal.misc to jdk.internal.access causing some tests in Java8AndUp to fail. To reuse as little code as possible I've moved all the tests that were in src_110 to a folder called src_110_up which will be used for versions 11+. I've wrapped the uses of SharedSecrets and JavaLangAccess into a class called InternalAccessor. There is one InternalAccessor for Java 11 in src_110 and one for Java 12 in src_120.
I've also added a latest_exclude_12.xml and jvmtitests_excludes_12.xml which were causing FileNotFoundExceptions in the tests
Fixed runtime build failures, need add-exports
fyi @llxia