Deprecate toUpperCase and toLowerCase Lithuanian tests from OpenJ9 #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoptOpenJDK testing already has coverage for all locales and the various special cases, including Lithuanian. Since Java 9 onward we have started to use the OpenJDK implementations for `toUpperCase` and `toLowerCase`. As such we will pick up updated test material from Adopt whenever the Unicode version changes in future Java releases and we will not have to continuously update these Lithuanian tests. See the discussion in eclipse-openj9#4659 for further details and examples of tests. Fixes: eclipse-openj9#4659 Signed-off-by: Filip Jeremic <[email protected]>
fjeremic
force-pushed
the
deprecate-lithuanian
branch
from
1435871 to
59db62c
Compare
|
@pshipton do we have a Jenkins JDK12 trigger yet? |
pshipton
approved these changes
Feb 8, 2019
|
While we wait for PR builds, could have also launched jdk12 Grinder against this branch. |
|
Not sure of the point in testing the removal of a test. It obviously can no longer fail. |
|
agree, I was just responding to #4671 (comment) without too much thought applied :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdoptOpenJDK testing already has coverage for all locales and the
various special cases, including Lithuanian. Since Java 9 onward we
have started to use the OpenJDK implementations for
toUpperCaseandtoLowerCase. As such we will pick up updated test material from Adoptwhenever the Unicode version changes in future Java releases and we
will not have to continuously update these Lithuanian tests.
See the discussion in #4659 for further details and examples of tests.
Fixes: #4659
Signed-off-by: Filip Jeremic [email protected]