Move ddrgen step outside of building VM. #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the run ddrgen step outside of the building VM step in order to resolve DDR dependencies better. Signed-off-by: Mike Zhang <[email protected]>
This was referenced Aug 13, 2018
|
@keithc-ca can you review this and the extension repo changes please? |
|
I think the PRs in the extension repos (with requested updates) can safely be delivered before (and without) this. Without this change, the work will just happen earlier leaving nothing to be done in |
keithc-ca
approved these changes
Aug 14, 2018
|
Jenkins test sanity plinux jdk8,jdk10 |
1 similar comment
|
Jenkins test sanity plinux jdk8,jdk10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the run ddrgen step outside of the building VM step in order to
resolve DDR dependencies better.
This PR removes the code that runs ddrgen during building the VM, and needs to be delivered together with the extensions repo PRs which move running ddrgen to after the VM is built.
jdk8: ibmruntimes/openj9-openjdk-jdk8#110
jdk9: ibmruntimes/openj9-openjdk-jdk9#175
jdk10: ibmruntimes/openj9-openjdk-jdk10#55
jdk11: ibmruntimes/openj9-openjdk-jdk11#11
jdk12: ibmruntimes/openj9-openjdk-jdk#24
Signed-off-by: Mike Zhang [email protected]