Move ddrgen step after building vm #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikezhang1234567890
force-pushed
the
ddr-compile
branch
from
d9c6264 to
9b8bfd6
Compare
mikezhang1234567890
force-pushed
the
ddr-compile
branch
from
6cf3cd1 to
d56b84b
Compare
Add j9ddr.dat as a target run after building the VM so that ddrgen is moved outside of the build VM step. This helps resolve DDR dependencies and ddrgen is only run if the file does not exist or needs to updating. Signed-off-by: mikezhang <[email protected]>
mikezhang1234567890
force-pushed
the
ddr-compile
branch
from
d56b84b to
b182e7d
Compare
keithc-ca
approved these changes
Aug 16, 2018
jasonkatonica
pushed a commit
to jasonkatonica/openj9-openjdk-jdk
that referenced
this pull request
Mar 17, 2023
…Granularity Expand OpenSSL Version granularity
tajila
pushed a commit
to tajila/openj9-openjdk-jdk
that referenced
this pull request
Oct 23, 2023
Fix missing definition of harfbuzz function on AIX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the run ddrgen step outside of the building VM step in order to
resolve DDR dependencies better.
This PR moves the run ddrgen step to after the VM is built, and needs to be delivered together with eclipse-openj9/openj9#2588.
Signed-off-by: mikezhang [email protected]