Move ddrgen step after building VM #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Aug 13, 2018
closed/OpenJ9.gmk
Outdated
| @@ -70,6 +70,9 @@ OPENJ9_VM_FILES := \ | |||
| # | |||
|
|
|||
| ifeq (true,$(OPENJ9_ENABLE_DDR)) | |||
| $(OUTPUT_ROOT)/vm/j9ddr.dat : | |||
There was a problem hiding this comment.
This should list the prerequisites so j9ddr.dat will be updated when necessary.
mikezhang1234567890
force-pushed
the
ddr-compile
branch
from
54c66dc to
50550bc
Compare
keithc-ca
reviewed
Aug 14, 2018
closed/OpenJ9.gmk
Outdated
| @@ -70,6 +70,13 @@ OPENJ9_VM_FILES := \ | |||
| # | |||
|
|
|||
| ifeq (true,$(OPENJ9_ENABLE_DDR)) | |||
| $(OUTPUT_ROOT)/vm/j9ddr.dat : run-ddrgen | |||
| run-ddrgen : | |||
There was a problem hiding this comment.
There should be a rule
.PHONY : run-ddrgen
736751d to
6df4861
Compare
|
@keithc-ca can you review again please? |
keithc-ca
reviewed
Aug 15, 2018
closed/OpenJ9.gmk
Outdated
| .PHONY : run-ddrgen | ||
| $(OUTPUT_ROOT)/vm/j9ddr.dat : run-ddrgen | ||
| run-ddrgen : | ||
| export $(EXPORT_MSVS_ENV_VARS) \ |
There was a problem hiding this comment.
This may not work well when EXPORT_MSVS_ENV_VARS is empty. Without arguments, export (on the versions of bash I tested) just dumps the existing environment variables. We could move OPENJDK_VERSION_NUMBER_FOUR_POSITIONS and VERSION_MAJOR into the export command to avoid that.
mikezhang1234567890
force-pushed
the
ddr-compile
branch
from
6df4861 to
a44fc05
Compare
Move the run ddrgen step outside of the building VM step in order to resolve DDR dependencies better. Signed-off-by: mikezhang <[email protected]>
mikezhang1234567890
force-pushed
the
ddr-compile
branch
from
a44fc05 to
6db0eb2
Compare
keithc-ca
approved these changes
Aug 15, 2018
|
Jenkins compile plinux,win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the run ddrgen step outside of the building VM step in order to
resolve DDR dependencies better.
This PR moves the run ddrgen step to after the VM is built, and needs to be delivered together with eclipse-openj9/openj9#2588.
Signed-off-by: mikezhang [email protected]