Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install MSVC2017 for OpenJ9 windows compile machines #2469

Closed
jdekonin opened this issue Jul 24, 2018 · 10 comments
Closed

Install MSVC2017 for OpenJ9 windows compile machines #2469

jdekonin opened this issue Jul 24, 2018 · 10 comments

Comments

@jdekonin
Copy link
Contributor

jdekonin commented Jul 24, 2018

As per #1697 Windows will support compiling with VS2017 shortly once the changes are merged. VS2017 needs to be installed on the build machines and then used to build JDK11.

@fjeremic fjeremic changed the title Install MSVC2017 for OpenJ9 window compile machines Install MSVC2017 for OpenJ9 windows compile machines Jul 25, 2018
@ChengJin01
Copy link

ChengJin01 commented Jul 27, 2018

@jdekonin, I believe some Ansible scripts https://github.com/AdoptOpenJDK/openjdk-infrastructure need to be updated to install VS2017. If so, I will get started to figure out how to get this work.

@ChengJin01
Copy link

I already created a change for VS2017 at https://github.com/ChengJin01/openjdk-infrastructure/tree/update_install_vs2017. @jdekonin is helping to verify whether it works via Ansible Tower.

@vsebe
Copy link
Contributor

vsebe commented Sep 6, 2018

Installed MingWG-W64 8.1 and VS2017 on windows machines:

  • win2012r2-x86-1
  • win2012r2-x86-2
  • win2012r2-x86-3
  • win2012r2-x86-4

@vsebe
Copy link
Contributor

vsebe commented Sep 6, 2018

To enable VS2017 see: #2792

@vsebe
Copy link
Contributor

vsebe commented Sep 6, 2018

Playbook update for MinGW: adoptium/infrastructure#479

@vsebe
Copy link
Contributor

vsebe commented Sep 6, 2018

JDK11 build
Failure: make[5]: *** [run_omrddrgen.mk:73: ../j9ddr.dat] Segmentation fault - know issue: eclipse-omr/omr#2885

@ChengJin01
Copy link

For the temporary solution, the crash can be avoided by specifying --enable-ddr=no to disable DDR-related code as DDR doesn't affect the operation of VM.
e.g.
bash configure --with-freemarker-jar=/cygdrive/c/openjdk/freemarker.jar --with-boot-jdk=/cygdrive/c/openjdk/jdk10 --with-toolchain-version=2017 --enable-ddr=no --disable-ccache`

@pshipton
Copy link
Member

Note --enable-ddr=no is no longer required since eclipse-omr/omr#2944 was merged and promoted to openj9.

@pshipton
Copy link
Member

Heads up that we are investigating using clang instead of mingw on Windows. If performance testing looks good we'll have to install clang on the builds machines as well.

@pshipton
Copy link
Member

pshipton commented Oct 5, 2018

MSVC2017 is installed and in use for Java 11 builds.

@pshipton pshipton closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants