-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Install MinGW-W64 on Windows #479
Conversation
OpenJ9 requires MinGW-W64 8 for JDK11 and up with MSVS 2017. v8.x is not available yet for cygwin.
MinGW is installed from binary. There is no silent option for the windows installer. The installer also is configurable - choose installation directory (opting to install it in c:/mingw-w64 not in c:/Program File to avoid spaces on the path), architecture and thread. |
@sxa555 fyi |
@jdekonin fyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you break out 7-Zip into a separate section from MingGW (i.e. a separate role) and add a comment to the name
field saying "Added for extracting MinGW". Also add something to the name
field for MinGW saying it's needed for OpenJ9 (This is something I want to start doing to document why we have things in the playbook since it's getting rather vague :-) )
43a6aac
to
11bb5ad
Compare
@sxa555 - I have broken it down in two playbooks as required. |
- install 7zip - install MinGW from a 7zip package MinGW-W64 is required to compile OpenJ9. Signed-off-by: Violeta Sebe <[email protected]>
11bb5ad
to
288029e
Compare
Just saw this on
Is this related or a red herring? I note that this is a reference to mingw32 so referencing @ali-ince as well |
This PR is for VS 2017. The <mingw-w64_install_dir>/bin directory should be added to the PATH. This is done in the Jenkins files for OpenJ9 build pipelines. For older toolchain versions - VS2010, VS2013 - the mingw64-x86_64-gcc-g++ package available with cygwing works fine.
|
@vsebe Thanks! That's a great write up - I'll split it into a different issue |
Signed-off-by: Violeta Sebe [email protected]