Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault detected when running ddrgen #2885

Closed
ChengJin01 opened this issue Aug 22, 2018 · 2 comments
Closed

Segmentation fault detected when running ddrgen #2885

ChengJin01 opened this issue Aug 22, 2018 · 2 comments

Comments

@ChengJin01
Copy link

ChengJin01 commented Aug 22, 2018

Segmentation fault occurred in ddrgen when compiling the latest version of OpenJDK11/OpenJ9/OMR with VS2017.

../ddrgen --blob ../j9ddr.dat --superset ../superset.dat --blacklist blacklist --macrolist ../mac    roList --overrides overrides --show-empty  \
        ../j9ddr_misc29.pdb ../j9gc29.pdb ../j9jvmti29.pdb ../j9prt29.pdb ../j9shr29.pdb ../j9thr    29.pdb ../j9trc29.pdb ../j9vm29.pdb ../jclse11_29.pdb
make[5]: *** [run_omrddrgen.mk:73: ../j9ddr.dat] Segmentation fault
make[5]: Leaving directory '/cygdrive/c/temp1/openj9-openjdk-jdk11/build/windows-x86_64-normal-se    rver-release/vm/ddr'

It worked good last month after fixing all issues with OpenJDK11 on Windows.

I am not too sure whether the problem was caused by recent changes merged in omr/ddr

@keithc-ca, @DanHeidinga

@keithc-ca
Copy link
Contributor

I was able to reproduce this. It fails because it can't resolve typedefs like omr_error_t immediately.
The PostponedType mechanism handles delayed resolution of field types, but PdbScanner::createTypedef also want to copy the type size into the typedef. Perhaps another (later) pass can update sizes of typedefs.

@keithc-ca
Copy link
Contributor

@ChengJin01 This should be fixed by #2944: please close if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants