Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup eclipse CI integration for ibmruntimes/openj9-openjdk-jdk11 repo #2089

Closed
andrew-m-leonard opened this issue Jun 6, 2018 · 20 comments
Closed

Comments

@andrew-m-leonard
Copy link
Contributor

andrew-m-leonard commented Jun 6, 2018

Please can we setup CI integration for the openjdk extensions "head" (java 11) repository, similar to the jdk8/9/10 setups....

  • copyright/line end checks
  • nightly builds, build/sanity/extended
  • PR builds

https://github.com/ibmruntimes/openj9-openjdk-jdk

Note the sanity/extended tests don't build yet for head/java11 - #2071

@pshipton
Copy link
Member

pshipton commented Jun 6, 2018

@jdekonin fyi

@pshipton pshipton added the jdk11 label Jun 6, 2018
@pshipton pshipton added this to the Release 0.10.0 milestone Jun 6, 2018
@irinarada
Copy link

@jdekonin - do we have an ETA for these builds? We have many features that need testing...

@jdekonin
Copy link
Contributor

I have been busy with IBM internal activities. But I'm aiming for end of this week; its my top OpenJ9 priority.

@pshipton
Copy link
Member

pshipton commented Jul 17, 2018

Note there are 2 things we want.

  1. Integration for ibmruntimes/openj9-openjdk-jdk11, which is the priority
  2. Integration for ibmruntimes/openj9-openjdk-jdk, which is the head stream, used for Java 12 atm, and may not actually work at any given time, but we should get everything in place.

@jdekonin
Copy link
Contributor

Copyright and LineEnding checks were done for JDK11 and JDK(next) repos under
ibmruntimes/openj9-openjdk-jdk11/issues/4
ibmruntimes/openj9-openjdk-jdk/issues/3

@jdekonin
Copy link
Contributor

jdekonin commented Jul 17, 2018

  • Compile OpenJ9 PR
  • Compile OpenJDK11 PR
  • Sanity OpenJ9 PR
  • Sanity OpenJDK11 PR
  • Extended OpenJ9 PR
  • Extended OpenJDK11 PR
  • JDK11 Build Pipelines
  • JDK11 sanity* and extended* test pipelines

Looks like there is a new AIX dependency ??

#2414

@jdekonin
Copy link
Contributor

The build, sanity* and extended* pipelines are setup, although I cannot test until #2414 is merged. The openjdk-test specific files have also not been created. I believe @smlambert is doing this work under adoptium/aqa-tests#483

@llxia
Copy link
Contributor

llxia commented Jul 20, 2018

The build, sanity* and extended* pipelines are setup

Even though the sanity* and extended* pipelines are setup, they need to be updated as we will need to pass in JAVA_VERSION as parameter and we will not have java version specific Jenkins file. For example, openjdk11_ppc64_aix will not be created.

@jdekonin
Copy link
Contributor

AIX dependency details
adoptium/infrastructure#411

@jdekonin
Copy link
Contributor

Note that while the PR jobs have been created they appear to be very unstable wrt SDK compilation. I am not certain if this is because of code or setup. Existing PR jobs are not setup for general use until that can be determined.

@jdekonin
Copy link
Contributor

For testing openjdk-jdk11 pull request builds I opened this PR. All builds are triggering but there are some known failures for which I'll be raising defects.
ibmruntimes/openj9-openjdk-jdk11#6

@jdekonin
Copy link
Contributor

#2468 - AIX
#2469 - Windows apparently requires MSVC2017
#2476 - pLinux compilation hangs, although it works sometimes
#2388 & #2329 - zLinux is slower than it should be, testing is very slow.

In my tests, I've been seeing occassional issues on xlinux as well.

@pshipton
Copy link
Member

Please change xlinux to compile with gcc 7. Let me know if this is better handled via a separate issue.
zlinux as well if its working. Next week the slowness problems should be resolved by eclipse-omr/omr#2796

@pshipton
Copy link
Member

pshipton commented Jul 26, 2018

Not sure Windows requires VS2017. @ChengJin01 will confirm if VS2013 also works. It should work with VS2013 or VS2017 once the changes from #1697 are merged.

@pshipton
Copy link
Member

Actually, not sure zlinux compiles with gcc 7 yet, @babsingh is checking.

@babsingh
Copy link
Contributor

babsingh commented Jul 26, 2018

JDK11 zLinux didn't compile with gcc-7.3.0. I saw two errors:

  1. error: module not found: jdk.hotspot.agent
  2. error: array subscript is below array bounds
/root/openj9-openjdk-jdk11/src/java.base/share/native/libfdlibm/k_rem_pio2.c: In function ‘__j__kernel_rem_pio2’:
/root/openj9-openjdk-jdk11/src/java.base/share/native/libfdlibm/k_rem_pio2.c:255:27: error: array subscript is below array bounds [-Werror=array-bounds]
                 for(k=1;iq[jk-k]==0;k++);   /* k = no. of terms needed */
                         ~~^~~~~~

Compilation stopped due to the second error. The second error is related to OpenJDK native code.

OpenJDK Extensions repo used: https://github.com/ibmruntimes/openj9-openjdk-jdk11.

Build log: jdk11_zlinux_build.log

@ChengJin01
Copy link

ChengJin01 commented Jul 27, 2018

Already compiled with VS2013 and the latest JDK11 & OpenJ9 & my OMR changes and it works as expected.

...
A new configuration has been successfully created in
/cygdrive/c/temp/openj9-openjdk-jdk11/build/windows-x86_64-normal-server-release
using configure arguments '--disable-warnings-as-errors --with-boot-jdk=/cygdrive/c/temp/internal_jdk_10.0.1 --with-freemarker-jar=/cygdrive/c/temp/freemarker.jar'.

Configuration summary:
* Debug level:    release
* HS debug level: product
* JVM variants:   server
* JVM features:   server: 'cds cmsgc compiler1 compiler2 epsilongc g1gc graal jfr jni-check jvmci jvmti management nmt parallelgc serialgc services vm-structs'
* OpenJDK target: OS: windows, CPU architecture: x86, address length: 64
* Version string: 11-internal+0-adhoc.Administrator.openj9-openjdk-jdk11 (11-internal)

Tools summary:
* Environment:    cygwin version 2.10.0(0.325/5/3) (root at /cygdrive/c/cygwin64)
* Boot JDK:       openjdk version "10.0.1-adoptopenjdk" 2018-04-17  OpenJDK Runtime Environment (build 10.0.1-adoptopenjdk+10)  OpenJDK 64-Bit Server VM (build 10.0.1-adoptopenjdk+10, mixed mode)   (at /cygdrive/c/temp/internal_jdk_10.0.1)
* Toolchain:      microsoft (Microsoft Visual Studio 2013)
* C Compiler:     Version 18.00.21005.1 (at /cygdrive/c/progra~2/micros~3.0/vc/bin/amd64/cl)
* C++ Compiler:   Version 18.00.21005.1 (at /cygdrive/c/progra~2/micros~3.0/vc/bin/amd64/cl)

Build performance summary:
* Cores to use:   4
* Memory limit:   16383 MB
...
make all
...
Creating jdk image
Stopping sjavac server
Finished building target 'all' in configuration 'windows-x86_64-normal-server-release'

There is no problem with java -version

Administrator@JCHTORWIN101 /cygdrive/c/temp/openj9-openjdk-jdk11/build/windows-x86_64-normal-server-release/images
$ jdk/bin/java  -version
openjdk version "11-internal" 2018-09-25
OpenJDK Runtime Environment (build 11-internal+0-adhoc.Administrator.openj9-openjdk-jdk11)
Eclipse OpenJ9 VM (build master-9db8db0e, JRE 11 Windows 8.1 amd64-64-Bit Compressed References 20180726_000000 (JIT enabled, AOT enabled)
OpenJ9   - 9db8db0e
OMR      - a96a2227
JCL      - e5c64f513d based on jdk-11+21)

Administrator@JCHTORWIN101 /cygdrive/c/temp/openj9-openjdk-jdk11/build/windows-x86_64-normal-server-release/images
$ jdk/bin/java  -Xint -version
openjdk version "11-internal" 2018-09-25
OpenJDK Runtime Environment (build 11-internal+0-adhoc.Administrator.openj9-openjdk-jdk11)
Eclipse OpenJ9 VM (build master-9db8db0e, JRE 11 Windows 8.1 amd64-64-Bit Compressed References 20180726_000000 (JIT disabled, AOT disabled)
OpenJ9   - 9db8db0e
OMR      - a96a2227
JCL      - e5c64f513d based on jdk-11+21)

jdk11_build_win_vs2013_log.txt

@jdekonin
Copy link
Contributor

jdekonin commented Aug 1, 2018

#2527 opened to address openjdk next/head. This issue covers jdk11 requirements.
This issue abstract should be changed to reflect actual work performed ...openjdk-jdk11...

Remaining issues that shouldn't block the closure of this issue :
#2468 - AIX
#2469 - Windows MSVC2017, isn't a blocker as jdk11 will compile on msvc2013
#2476 - pLinux compilation hangs, although it works sometimes

If there is agreement, I believe this can be closed.

@pshipton pshipton changed the title Setup eclipse CI integration for ibmruntimes/openj9-openjdk-jdk repo Setup eclipse CI integration for ibmruntimes/openj9-openjdk-jdk11 repo Aug 1, 2018
@pshipton
Copy link
Member

pshipton commented Aug 1, 2018

You could retry plinux. Keith mentioned it used to hang for him but doesn't any more.

@pshipton pshipton closed this as completed Aug 1, 2018
@babsingh
Copy link
Contributor

babsingh commented Aug 1, 2018

@pshipton JDK11 pLinux builds fine.

openjdk version "11-internal" 2018-09-25
OpenJDK Runtime Environment (build 11-internal+0-adhoc.root.openj9-openjdk-jdk11)
Eclipse OpenJ9 VM (build master-9f239b8, JRE 11 Linux ppc64le-64-Bit Compressed References 20180801_000000 (JIT enabled, AOT enabled)
OpenJ9   - 9f239b8
OMR      - ed95a04
JCL      - e4b4f66 based on jdk-11+24)

Build log: jdk11_plinux_build.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants