AIX compile failure with JDK11 extensions

[jdekonin]

https://ci.eclipse.org/openj9/job/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/1/console

Actually looks like we are just past the openj9 native compilation and into java.base-libs

00:27:57.168 ld: 0711-224 WARNING: Duplicate symbol: .sigaction
00:27:57.169 ld: 0711-224 WARNING: Duplicate symbol: sigaction
00:27:57.169 ld: 0711-344 See the loadmap file /home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/build/aix-ppc64-normal-server-release/support/native/java.base/libjsig/libjsig.loadmap for more information.
00:27:57.169 ld: 0711-407 ERROR: Symbol .sigaction
00:27:57.169 	Visibility is not allowed on a reference to an imported symbol.
00:27:57.169 Lib-java.base.gmk:139: recipe for target '/home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/build/aix-ppc64-normal-server-release/support/modules_libs/java.base/libjsig.so' failed
00:27:57.169 gmake[3]: *** [/home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/build/aix-ppc64-normal-server-release/support/modules_libs/java.base/libjsig.so] Error 8
00:27:57.169 gmake[3]: *** Waiting for unfinished jobs....
00:27:57.169 ld: 0711-224 WARNING: Duplicate symbol: .jio_snprintf
00:27:57.169 ld: 0711-224 WARNING: Duplicate symbol: jio_snprintf
00:27:57.169 ld: 0711-224 WARNING: Duplicate symbol: .jio_fprintf
00:27:57.169 ld: 0711-224 WARNING: Duplicate symbol: .isnan
00:27:57.169 ld: 0711-224 WARNING: Duplicate symbol: jio_fprintf
00:27:57.169 ld: 0711-344 See the loadmap file /home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/build/aix-ppc64-normal-server-release/support/native/java.base/libjava/libjava.loadmap for more information.
00:27:57.169 gmake[2]: *** [java.base-libs] Error 2

important bits (?) of libjsig.loadmap

...
ld: 0711-228 WARNING: Duplicate symbols were found while resolving symbols.
        The following duplicates were found:
 Symbol                    Source-File(Object) OR Import-File{Shared-object}
 ------------------------- -------------------------------------------------
 .sigaction                {/usr/lib/libpthread.a[shr_xpg5_64.o]}
    ** Duplicate **        /home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/src/java.base/unix/native/libjsig/jsig.c(/home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/build/aix-ppc64-normal-server-release/support/native/java.base/libjsig/jsig.o)
 sigaction                 {/usr/lib/libpthread.a[shr_xpg5_64.o]}
    ** Duplicate **        /home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/src/java.base/unix/native/libjsig/jsig.c(/home/u0020236/workspace/PullRequest-Sanity-JDK11-aix_ppc-64_cmprssptrs-OpenJDK11/build/aix-ppc64-normal-server-release/support/native/java.base/libjsig/jsig.o)
...
ld: 0711-407 ERROR: Symbol .sigaction
        Visibility is not allowed on a reference to an imported symbol.
...

[pshipton]

@keithc-ca you might look at this next

[keithc-ca]

In JDK10, there are separate versions of jsig.c for aix and linux; in JDK11 the aix version was folded into a single unix source.

[sxa]

Seen this in the adoptopenjdk CI as well (HotSpot and OpenJ9 builds) ... Commenting here so I get any updates on this issue ;-)

[andrew-m-leonard]

@sxa555 Has anyone found reports of this on AIX in the openjdk maillist or bug reports at all? if it fails with Hotspot at Adopt presumably they would hit the issue too?

[sxa]

I would expect so, yes (unless it's toolchain specific) although I don't follow whichever list you're referring to closely and I don't see an easy way to search it ...

[keithc-ca]

In JDK11 and JDK12, source files are compiled with -qvisibility=hidden when using xlc version other than 12.1. That doesn't seem to play well with link option -bexpall.

I'm investigating whether alternate definitions of JNIEXPORT and JNIIMPORT will fix this.

See also this open issue: https://bugs.openjdk.java.net/browse/JDK-8204541.

[keithc-ca]

This should be fixed via ibmruntimes/openj9-openjdk-jdk11#15.