Enable AIX build with xlc 13.1 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith W. Campbell <[email protected]>
Signed-off-by: Keith W. Campbell <[email protected]>
dnakamura
pushed a commit
to dnakamura/openj9-openjdk-jdk
that referenced
this pull request
Aug 30, 2021
Access nonce only when non-null
jasonkatonica
pushed a commit
to jasonkatonica/openj9-openjdk-jdk
that referenced
this pull request
Mar 17, 2023
Update the type of signature in NativeCrypto.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
JNIEXPORTandJNIIMPORTfor xlc version 13.1 or newer. Without this, almost no symbols are exported from shared libraries due to use of-qvisibility=hiddenas specified inmake/lib/LibCommon.gmk. The symptoms are reported in eclipse-openj9/openj9#2468.Unfortunately, this encounters a bug in xlc: it fails to parse what seems to be reasonable code. A workaround is required in just one place:
src/java.base/share/native/libjimage/NativeImageBuffer.cpp.This is a replay of ibmruntimes/openj9-openjdk-jdk11#15.