Java11 updates #483
Java11 updates #483
Conversation
smlambert
commented
Jul 19, 2018
smlambert
commented
- updates to enable Java11 testing
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
| Set parameter TARGET(openjdk, system, external, perf, jck etc.). | ||
| Set UPSTREAM_JOB_NAME(version_build_arch_os, for example: openjdk8_build_x86-64_linux) | ||
| Set JVM_VERSION(openjdk8, openjdk8-openj9, openjdk9, openjdk9-openj9, etc.*/ | ||
| LABEL='sw.os.linux&&hw.arch.ppcle' |
There was a problem hiding this comment.
should this be sw.os.linux&&hw.arch.ppc64le?
| @@ -0,0 +1,22 @@ | |||
| #!groovy | |||
| /* Template for test jobs on openjdk8 linux. Configure test job as parameterized. | |||
There was a problem hiding this comment.
This is comment should be removed as the file is not java version specific anymore.
Same issue in the rest of Jenkins file comments.
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
Signed-off-by: smlambert <[email protected]>
| @@ -26,10 +25,15 @@ def stageTestBinaries() { | |||
| } | |||
|
|
|||
| def setupEnv() { | |||
| // env.JAVA_VERSION = "${getJavaVersionFromJvmVersion()}" | |||
There was a problem hiding this comment.
Leaving this as comment, as I wish to return to it next week in a separate PR
| @@ -0,0 +1,18 @@ | |||
| #!groovy | |||
| LABEL='hw.arch.x86&&sw.os.win' | |||
There was a problem hiding this comment.
Should we use sw.os.windows according to adoptium/infrastructure#93?
Eclipse OpenJ9 is already updated to use sw.os.windows
There was a problem hiding this comment.
Yes we should use sw.os.windows, I will update and merge. Thanks!
|
Approve the change so we can get generic files in. wins file is not used in Eclipse Openj9, so it can be addressed later. |
Signed-off-by: smlambert <[email protected]>
|
When merged all existing jobs will need to update configuration with right jenkins file name. I will first try to update regression test jobs. |
|
Since I have not removed any of the versioned data jenkinsfiles, all the old builds will work as is (using the old files). We decided to push this in now, before the getJavaVersionFromJvmVersion() method is completely working, but I left the commented line in, as I plan to return to it this week, because then we could remove all of the versioned data jenkinsfiles and not have to make any updates to job config. |
