Update examples #162
Merged
Update examples #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update project templates and examples to - Lerna 6..x - Typescript 4.9 - Theia Community Release 1.29 - Newest version of the GLSP config dev package - Set minimal supported node version to 14. eclipse-glsp/glsp#676 eclipse-glsp/glsp#680 Update jenkins file to - ensure that we don't exhaust resource limits - enable error reporting when master builds fails eclipse-glsp/glsp#794
planger
requested changes
Dec 7, 2022
There was a problem hiding this comment.
Thank you @tortmayr! I tested all project templates with node 16 and they still work fine. For all of them I ran yarn build in the command line and yarn start in the client for testing, except for the Eclipse and VS Code template, where I've used the launch configs.
Just three things:
- The jenkinsfile seems to be broken.
- We need to update the READMEs too to reflect the requirement regarding the node version
- I had a change in the yarn.lock of the
java-emf-eclipseafter building. Did you miss adding the new yarn.lock?
tortmayr
force-pushed
the
issue/theiacr
branch
from
f2836b6 to
e356435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-glsp/glsp#676
eclipse-glsp/glsp#680
Update jenkins file to
eclipse-glsp/glsp#794