Address review feedback

eclipse-glsp · Dec 7, 2022 · e356435 · e356435
1 parent 350b933
commit e356435
Show file tree

Hide file tree

Showing 8 changed files with 141 additions and 2,393 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -249,34 +249,34 @@ pipeline {
             // Record maven,java warnings
             recordIssues enabledForFailure: true, skipPublishingChecks:true, tools: [mavenConsole(), java()]    
             }
-            failure {
+        }
+        failure {
             script {
-                    if (env.BRANCH_NAME == 'master') {
-                        echo "Build result FAILURE: Send email notification to ${EMAIL_TO}"
-                        emailext attachLog: true,
-                        body: 'Job: ${JOB_NAME}<br>Build Number: ${BUILD_NUMBER}<br>Build URL: ${BUILD_URL}',
-                        mimeType: 'text/html', subject: 'Build ${JOB_NAME} (#${BUILD_NUMBER}) FAILURE', to: "${EMAIL_TO}"
-                    }
+                if (env.BRANCH_NAME == 'master') {
+                    echo "Build result FAILURE: Send email notification to ${EMAIL_TO}"
+                    emailext attachLog: true,
+                    body: 'Job: ${JOB_NAME}<br>Build Number: ${BUILD_NUMBER}<br>Build URL: ${BUILD_URL}',
+                    mimeType: 'text/html', subject: 'Build ${JOB_NAME} (#${BUILD_NUMBER}) FAILURE', to: "${EMAIL_TO}"
                 }
             }
-            unstable {
-                script {
-                    if (env.BRANCH_NAME == 'master') {
-                        echo "Build result UNSTABLE: Send email notification to ${EMAIL_TO}"
-                        emailext attachLog: true,
-                        body: 'Job: ${JOB_NAME}<br>Build Number: ${BUILD_NUMBER}<br>Build URL: ${BUILD_URL}',
-                        mimeType: 'text/html', subject: 'Build ${JOB_NAME} (#${BUILD_NUMBER}) UNSTABLE', to: "${EMAIL_TO}"
-                    }
+        }
+        unstable {
+            script {
+                if (env.BRANCH_NAME == 'master') {
+                    echo "Build result UNSTABLE: Send email notification to ${EMAIL_TO}"
+                    emailext attachLog: true,
+                    body: 'Job: ${JOB_NAME}<br>Build Number: ${BUILD_NUMBER}<br>Build URL: ${BUILD_URL}',
+                    mimeType: 'text/html', subject: 'Build ${JOB_NAME} (#${BUILD_NUMBER}) UNSTABLE', to: "${EMAIL_TO}"
                 }
             }
-            fixed {
-                script {
-                    if (env.BRANCH_NAME == 'master') {
-                        echo "Build back to normal: Send email notification to ${EMAIL_TO}"
-                        emailext attachLog: false,
-                        body: 'Job: ${JOB_NAME}<br>Build Number: ${BUILD_NUMBER}<br>Build URL: ${BUILD_URL}',
-                        mimeType: 'text/html', subject: 'Build ${JOB_NAME} back to normal (#${BUILD_NUMBER})', to: "${EMAIL_TO}"
-                    }
+        }
+        fixed {
+            script {
+                if (env.BRANCH_NAME == 'master') {
+                    echo "Build back to normal: Send email notification to ${EMAIL_TO}"
+                    emailext attachLog: false,
+                    body: 'Job: ${JOB_NAME}<br>Build Number: ${BUILD_NUMBER}<br>Build URL: ${BUILD_URL}',
+                    mimeType: 'text/html', subject: 'Build ${JOB_NAME} back to normal (#${BUILD_NUMBER})', to: "${EMAIL_TO}"
                 }
             }
         }

diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ Each example is self-contained and provides both, an example diagram client (`gl
 
 The following libraries/frameworks need to be installed on your system:
 
--   [Node.js](https://nodejs.org/en/) `>= 12.14.1`
+-   [Node.js](https://nodejs.org/en/) `>=14.18.0`
 -   [Yarn](https://classic.yarnpkg.com/en/docs/install#debian-stable) `>=1.7.0`
 -   [Java](https://www.oracle.com/java/technologies/javase-jdk11-downloads.html) `>=11`
 -   [Maven](https://maven.apache.org/) `>=3.6.0`

diff --git a/project-templates/java-emf-eclipse/README.md b/project-templates/java-emf-eclipse/README.md
@@ -39,7 +39,7 @@ The most important entry points are:
 
 The following libraries/frameworks need to be installed on your system:
 
--   [Node.js](https://nodejs.org/en/) `>= 12.14.1`
+-   [Node.js](https://nodejs.org/en/) `>=14.18.0`
 -   [Yarn](https://classic.yarnpkg.com/en/docs/install#debian-stable) `>=1.7.0`
 -   [Java](https://adoptium.net/temurin/releases) `>=11`
 -   [Maven](https://maven.apache.org/) `>=3.6.0`