Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH actions to use Node 16 tasks #21763

Closed
nickboldt opened this issue Oct 13, 2022 · 5 comments
Closed

Update GH actions to use Node 16 tasks #21763

nickboldt opened this issue Oct 13, 2022 · 5 comments
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Oct 13, 2022 •
edited
Loading

Is your task related to a problem? Please describe

Node.js 12 actions are deprecated. For more information see: 
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. 
Please update the following actions to use Node.js 16: 
actions/checkout, docker/login-action, docker/login-action, actions/setup-python, 
actions/setup-java, actions/setup-java, actions/setup-python, docker/login-action, 
docker/login-action, actions/checkout

-- https://github.com/eclipse-che/che-release/actions/runs/3233426139

So, anywhere we have GHA scripts that use old versions of the above actions, we should update to the latst node16 based versions.

  • eclipse/che* repos
  • eclipse-che/* repos
  • che-incubator/* repos
  • che-release repo
  • etc.

Describe the solution you'd like

So, anywherer we have GHA scripts that use old versions of the above actions, we should update to the latst node16 based versions.

Describe alternatives you've considered

No response

Additional context

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Oct 13, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 13, 2022
@nickboldt nickboldt added severity/P2 Has a minor but important impact to the usage or development of the system. area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) labels Oct 13, 2022
@nickboldt nickboldt mentioned this issue Oct 13, 2022
Closed
67 tasks
@nickboldt nickboldt mentioned this issue Nov 1, 2022
Closed
73 tasks
@nickboldt nickboldt mentioned this issue Nov 22, 2022
Closed
68 tasks
@nickboldt nickboldt mentioned this issue Dec 7, 2022
Closed
82 tasks
This was referenced Dec 8, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@SDawley
Copy link
Contributor

SDawley commented Dec 14, 2022

Ongoing list of actions that I've found could not be updated because they don't have a node16 version:

This was referenced Dec 20, 2022
Merged
Merged
@nickboldt nickboldt mentioned this issue Dec 21, 2022
Merged
@dmytro-ndp dmytro-ndp mentioned this issue Dec 24, 2022
Closed
@nickboldt nickboldt reopened this Jan 4, 2023
@nickboldt
Copy link
Contributor Author

nickboldt commented Jan 4, 2023 •
edited
Loading

Seems that after this update, some taks require additional configuration:

@nickboldt nickboldt mentioned this issue Jan 4, 2023
Merged
9 tasks
nickboldt added a commit that referenced this issue Jan 4, 2023
@nickboldt
chore: #21763 - bump to latest Adopt JDK 11
f7702b4 
Change-Id: Ib6863018dff009b6fe2ec15f11758935b4c49ade
Signed-off-by: Nick Boldt <[email protected]>
@nickboldt
Copy link
Contributor Author

nickboldt commented Jan 4, 2023 •
edited
Loading

PRs:

Note that some Che projects uses Temurin and some use Adopt. Not sure why the discrepancy, but here we are.

This was referenced Jan 4, 2023
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 5, 2023
Merged
Closed
Merged
nickboldt added a commit that referenced this issue Jan 5, 2023
@nickboldt
chore: #21763 - bump to latest Adopt JDK 11 (#21910)
93ed226 
Change-Id: Ib6863018dff009b6fe2ec15f11758935b4c49ade
Signed-off-by: Nick Boldt <[email protected]>

Signed-off-by: Nick Boldt <[email protected]>
This was referenced Jan 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@nickboldt nickboldt mentioned this issue Jan 10, 2023
Closed
60 tasks
@SDawley
Copy link
Contributor

SDawley commented Jan 23, 2023

I think every repo has been updated now, closing.

@SDawley SDawley closed this as completed Jan 23, 2023
@azatsarynnyy azatsarynnyy mentioned this issue Feb 8, 2023
Merged
@azatsarynnyy
Copy link
Member

and one more che-incubator/che-code#175 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickboldt @azatsarynnyy @mkuznyetsov @che-bot @SDawley