Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update GitHub actions to use node 16 and Ubuntu to latest #686

Closed
wants to merge 2 commits into from

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented Dec 9, 2022

Signed-off-by: sdawley [email protected]

What does this PR do?

Update GitHub actions to use node 16 and Ubuntu to latest

What issues does this PR fix or reference?

eclipse-che/che#21763

Is it tested? How?

Release Notes

Docs PR

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SDawley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2022

Hi @SDawley. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@che-bot
Copy link
Contributor

che-bot commented Dec 9, 2022

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #686 (97f425a) into main (013b7c5) will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   63.23%   62.40%   -0.84%     
==========================================
  Files         285      288       +3     
  Lines        8781     8935     +154     
  Branches     1411     1434      +23     
==========================================
+ Hits         5553     5576      +23     
- Misses       2990     3119     +129     
- Partials      238      240       +2     
Flag Coverage Δ
unittests 62.40% <ø> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oard-frontend/src/pages/WorkspaceDetails/index.tsx 72.32% <0.00%> (-2.68%) ⬇️
...oard-frontend/src/store/DevfileRegistries/index.ts 65.92% <0.00%> (-0.26%) ⬇️
...ackages/dashboard-backend/src/constants/schemas.ts 100.00% <0.00%> (ø)
.../dashboard-frontend/src/services/helpers/editor.ts 68.18% <0.00%> (ø)
...s/WorkspaceDetails/EditorTab/EditorTools/index.tsx
...end/src/pages/WorkspaceDetails/EditorTab/index.tsx
...-frontend/src/components/WorkspaceEditor/index.tsx 0.00% <0.00%> (ø)
...s/WorkspaceDetails/DevworkspaceEditorTab/index.tsx 0.00% <0.00%> (ø)
...oard-frontend/src/components/EditorTools/index.tsx 0.00% <0.00%> (ø)
.../pages/WorkspaceDetails/DevfileEditorTab/index.tsx 59.37% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SDawley could you please open PR from the origin branch (not fork), otherwise build checks will be failing

@nickboldt
Copy link
Contributor

@SDawley could you please open PR from the origin branch (not fork), otherwise build checks will be failing

I'm not sure non-committers can create topic branches in the origin. Yet one more reason to get @SDawley her committership :D

@che-bot
Copy link
Contributor

che-bot commented Dec 21, 2022

Click here to review and test in web IDE: Contribute

@nickboldt
Copy link
Contributor

Replaced by #692 which uses origin fork so should pass the tests.

@nickboldt nickboldt closed this Dec 21, 2022
nickboldt added a commit that referenced this pull request Dec 21, 2022
…#692)

* Chore: Update GitHub actions to use node 16 and Ubuntu to latest

Signed-off-by: sdawley <[email protected]>

* fix: set Ubuntu to 22.04 specifically

Signed-off-by: sdawley <[email protected]>

Signed-off-by: sdawley <[email protected]>
Co-authored-by: sdawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants