-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of done for Pull Requests #17486
Comments
Here is an example of what could be done for PR (updating template) |
@benoitf, @l0rd: WDYT about dividing the list by mandatory and optional sections to simplify PR approval decision? Mandatory: (1). Code produced (No TODO items on the code, tickets are created for them) Optional: (10). Any build/deployment/configuration changes are implemented, tested, documented and communicated (Operational documentation) |
@dmytro-ndp I think that we should distinguish between points that can be mandatory for the the particular PR (docs updates for example) and points that are always optional (video recording). I would remove optionals (video recording) from the the checklist since it's mentioned in the description (screen capture or screencast). |
@benoitf thinking about this afternoon discussion I am wondering if we should not provide a more compact checklist and then provide detailed explanation in the wiki. For example:
|
…on of done on PR eclipse-che#17486 Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…on of done on PR eclipse-che#17486 Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…on of done on PR eclipse-che#17486 Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…on of done on PR eclipse-che#17486 Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…on of done on PR #17486 Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Is your task related to a problem? Please describe.
Here is an updated PRs Approval Checklist:
The things a reviewer needs to verify before approving a PR (in italic those checks that can/should be automated):
Has a milestone and a type (bug/feature/task) or is linked to issue with milestone and type
This definition of done applies to all the work that is merged into the Che code repositories. Therefore it should be applied to all Pull Requests and is part of the code review. It is both reviewers’ and the pull request creators’ responsibility to ensure that it has been followed..
The text was updated successfully, but these errors were encountered: