chore(github): Update the pull request template to match new definition of done on PR #17627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
che-bot
added
status/code-review
|
[crw-ci-test] |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
mmorhun
reviewed
Aug 17, 2020
l0rd
approved these changes
Aug 17, 2020
sparkoo
reviewed
Aug 19, 2020
metlos
reviewed
Aug 19, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
…on of done on PR eclipse-che#17486 Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1 Signed-off-by: Florent Benoit <[email protected]>
|
@l0rd PR has been updated I've added links to each element to I've also updated the description of this PR to match the content of the template to see how it looks live |
|
@benoitf LGTM |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the pull request template to match with the new
definition of doneon pull requests.Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes #17486
How to test this PR?
you can try by opening PR against the repository https://github.com/benoitf/che-template-issues
I'm also using the PR template for this PR so you can see it live :-)
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1
Signed-off-by: Florent Benoit [email protected]