This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
chore(github): Update the template to match new definition of done on PR #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I632d9498d6c13808a21478424e01ca6244018fbe Signed-off-by: Florent Benoit <[email protected]>
benoitf
requested review from
ericwill,
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Devfiles tests failed. Re-trigger by |
JPinkney
reviewed
Oct 6, 2020
| --> | ||
|
|
||
| ### What does this PR do? | ||
|
|
||
|
|
||
| ### Screenshot/screencast of this PR | ||
| <!-- Please include a screenshot or a screencast explaining what is doing this PR --> |
There was a problem hiding this comment.
It all looks OK to me I'm just wondering if we need a screenshot/screencast for things in this repo
There was a problem hiding this comment.
it's optional but it could be what you bring with a devfile
For example if I add a quarkus devfile, then I can see a screenshot of theia + project + quarkus being started
or for a petclinic app, a screenshot of the running app
JPinkney
approved these changes
Oct 6, 2020
ericwill
approved these changes
Oct 6, 2020
monaka
pushed a commit
to PizzaFactory/che-devfile-registry
that referenced
this pull request
Oct 11, 2020
… PR (eclipse-che#289) Change-Id: I632d9498d6c13808a21478424e01ca6244018fbe Signed-off-by: Florent Benoit <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the new PR Template
What issues does this PR fix or reference?
eclipse-che/che#17486
Change-Id: I632d9498d6c13808a21478424e01ca6244018fbe
Signed-off-by: Florent Benoit [email protected]