-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set scc priority to null #1606
Conversation
Signed-off-by: Anatolii Bazko <[email protected]>
/retest |
2 similar comments
/retest |
/retest |
Codecov Report
@@ Coverage Diff @@
## main #1606 +/- ##
==========================================
- Coverage 58.69% 58.57% -0.13%
==========================================
Files 73 73
Lines 8457 8482 +25
==========================================
+ Hits 4964 4968 +4
- Misses 3162 3180 +18
- Partials 331 334 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, ibuziuk, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Build 3.5 :: operator_3.x/180: Console, Changes, Git Data |
Build 3.5 :: sync-to-downstream_3.x/2126: Console, Changes, Git Data |
Build 3.5 :: push-latest-container-to-quay_3.x/1605: Console, Changes, Git Data |
Build 3.5 :: update-digests_3.x/2010: Console, Changes, Git Data |
Build 3.5 :: push-latest-container-to-quay_3.x/1605: Copied: devspaces-rhel8-operator; /job/DS_CI/job/update-digests_3.x triggered; |
Build 3.5 :: copyIIBsToQuay/754: Console, Changes, Git Data |
Build 3.5 :: get-sources-rhpkg-container-build_3.x/2024: devspaces-operator : 3.x :: Build 50357862 : quay.io/devspaces/devspaces-rhel8-operator:3.5-23 |
Build 3.5 :: sync-to-downstream_3.x/2126: Build container: devspaces-operator synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2024 triggered; |
Build 3.5 :: operator_3.x/180: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2126 triggered |
Build 3.5 :: operator-bundle_3.x/802: Console, Changes, Git Data |
Build 3.5 :: sync-to-downstream_3.x/2127: Console, Changes, Git Data |
Build 3.5 :: push-latest-container-to-quay_3.x/1606: Console, Changes, Git Data |
Build 3.5 :: copyIIBsToQuay/755: Console, Changes, Git Data |
Build 3.5 :: push-latest-container-to-quay_3.x/1606: Copied: devspaces-operator-bundle; bundle-generated updated; |
Build 3.5 :: sync-to-downstream_3.x/2127: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2025 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.5 :: operator-bundle_3.x/802: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2127 triggered |
Build 3.5 :: dsc_3.x/606: Console, Changes, Git Data |
Build 3.5 :: update-digests_3.x/2010: Detected new images: rebuild operator-bundle |
Build 3.5 :: dsc_3.x/606: 3.5.0 CI |
* feat: configure workspace security context for container builds Fix eclipse-che/che#21770 Signed-off-by: Andrew Obuchowicz <[email protected]> * Set SCC allowPrivilegeEscalation to true when container build enabled (#1596) * Set SCC allowPrivilegeEscalation to true when container build enabled Running Podman inside a container in OpenShift requires the pod to have allowPrivilegeEscalation: true in its security context. * Fix tests Signed-off-by: Angel Misevski <[email protected]> * fix: set scc priority to null Signed-off-by: Anatolii Bazko <[email protected]> --------- Signed-off-by: Andrew Obuchowicz <[email protected]> Signed-off-by: Angel Misevski <[email protected]> Signed-off-by: Anatolii Bazko <[email protected]> Co-authored-by: Angel Misevski <[email protected]> Co-authored-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
* fix: set scc priority to null (#1606) Signed-off-by: Anatolii Bazko <[email protected]> * revert some changes Signed-off-by: Anatolii Bazko <[email protected]> --------- Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
Set scc priority to null
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-3894
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.