Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set scc priority to null #1606

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: set scc priority to null #1606

merged 1 commit into from
Jan 30, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 27, 2023

Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor Author

tolusha commented Jan 27, 2023

/retest

2 similar comments
@tolusha
Copy link
Contributor Author

tolusha commented Jan 27, 2023

/retest

@tolusha
Copy link
Contributor Author

tolusha commented Jan 27, 2023

/retest

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #1606 (f5314e6) into main (578e953) will decrease coverage by 0.13%.
The diff coverage is 27.58%.

@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
- Coverage   58.69%   58.57%   -0.13%     
==========================================
  Files          73       73              
  Lines        8457     8482      +25     
==========================================
+ Hits         4964     4968       +4     
- Misses       3162     3180      +18     
- Partials      331      334       +3     
Impacted Files Coverage Δ
pkg/deploy/labels.go 37.03% <0.00%> (-2.97%) ⬇️
pkg/deploy/container-build/container_build.go 61.26% <29.62%> (-5.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor Author

tolusha commented Jan 28, 2023

/retest

@tolusha tolusha merged commit 978a2d3 into main Jan 30, 2023
@tolusha tolusha deleted the CRW-3894 branch January 30, 2023 05:52
@devstudio-release
Copy link

Build 3.5 :: operator_3.x/180: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@che-bot che-bot added this to the 7.61 milestone Jan 30, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: update-digests_3.x/2010: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: push-latest-container-to-quay_3.x/1605: SUCCESS

Copied: devspaces-rhel8-operator; /job/DS_CI/job/update-digests_3.x triggered;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/754: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: sync-to-downstream_3.x/2126: SUCCESS

Build container: devspaces-operator synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2024 triggered;

@devstudio-release
Copy link

Build 3.5 :: operator_3.x/180: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2126 triggered

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/802: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/755: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: push-latest-container-to-quay_3.x/1606: SUCCESS

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.5 :: sync-to-downstream_3.x/2127: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2025 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/802: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2127 triggered

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/606: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: update-digests_3.x/2010: SUCCESS

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/802 triggered

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/606: SUCCESS

3.5.0 CI

nickboldt pushed a commit that referenced this pull request Jan 30, 2023
* feat: configure workspace security context for container builds

Fix eclipse-che/che#21770

Signed-off-by: Andrew Obuchowicz <[email protected]>

* Set SCC allowPrivilegeEscalation to true when container build enabled (#1596)

* Set SCC allowPrivilegeEscalation to true when container build enabled

Running Podman inside a container in OpenShift requires the pod to have
allowPrivilegeEscalation: true in its security context.

* Fix tests

Signed-off-by: Angel Misevski <[email protected]>

* fix: set scc priority to null

Signed-off-by: Anatolii Bazko <[email protected]>

---------

Signed-off-by: Andrew Obuchowicz <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Co-authored-by: Angel Misevski <[email protected]>
Co-authored-by: Anatolii Bazko <[email protected]>
tolusha added a commit that referenced this pull request Feb 3, 2023
tolusha added a commit that referenced this pull request Feb 3, 2023
* fix: set scc priority to null (#1606)

Signed-off-by: Anatolii Bazko <[email protected]>

* revert some changes

Signed-off-by: Anatolii Bazko <[email protected]>

---------

Signed-off-by: Anatolii Bazko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants