-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove priority from container-build SCC #1605
Conversation
Previously-applied workaround is no longer necessary, as SCC selection was fixed with eclipse-che/che#21770. Signed-off-by: Angel Misevski <[email protected]>
@amisevsk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tolusha we should backport it to 7.58.x to have it in 3.4 I believe
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should be closed in favor of #1606 |
What does this PR do?
Remove the priority field from the container-build SCC that is created by Che. Previously this field was introduced to workaround issue devfile/devworkspace-operator#884, and is no longer required since eclipse-che/che#21770 is resolved.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Closes eclipse-che/che#21959
How to test this PR?
restricted-runasuser
SCC created in step 2PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.