-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support spec.devEnvironments.podSchedulerName in CR #1565
Conversation
Signed-off-by: Andrew Obuchowicz <[email protected]>
Signed-off-by: Andrew Obuchowicz <[email protected]>
Fix eclipse-che/che#21770 Signed-off-by: Andrew Obuchowicz <[email protected]>
Signed-off-by: Andrew Obuchowicz <[email protected]>
Signed-off-by: Andrew Obuchowicz <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkwon17 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
+ Coverage 60.54% 60.56% +0.02%
==========================================
Files 73 73
Lines 6303 6307 +4
==========================================
+ Hits 3816 3820 +4
Misses 2147 2147
Partials 340 340
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6a74972
to
97ea796
Compare
Signed-off-by: David Kwon <[email protected]>
97ea796
to
49ff5e4
Compare
@dkwon17: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing in favour of #1565 |
* feat: configure workspace security context for container builds Fix eclipse-che/che#21770 Signed-off-by: Andrew Obuchowicz <[email protected]> * Set SCC allowPrivilegeEscalation to true when container build enabled (#1596) * Set SCC allowPrivilegeEscalation to true when container build enabled Running Podman inside a container in OpenShift requires the pod to have allowPrivilegeEscalation: true in its security context. * Fix tests Signed-off-by: Angel Misevski <[email protected]> * fix: set scc priority to null Signed-off-by: Anatolii Bazko <[email protected]> --------- Signed-off-by: Andrew Obuchowicz <[email protected]> Signed-off-by: Angel Misevski <[email protected]> Signed-off-by: Anatolii Bazko <[email protected]> Co-authored-by: Angel Misevski <[email protected]> Co-authored-by: Anatolii Bazko <[email protected]>
What does this PR do?
This PR is a draft PR because this PR depends on DWO 0.18.0, since that is when the
config.workspace.schedulerName
field would be introduced for the DWO config. This PR can still be tested, since the devworkspace-operator dependency in go.mod has been temporarily updated to point to this PR branch that introduced config.workspace.schedulerNameShould be merged after #1549 is merged
This PR introduces the
devEnvironments.podSchedulerName
field in the Che CR. When this field is set, it updates theconfig.workspace.schedulerName
field of the Che-operator-managed DWO config.Screenshot/screencast of this PR
In this demo:
devEnvironments.podSchedulerName
field is set totesting123
.workspace.schedulerName
field is set totesting123
.schedulerName of
testing123`.devEnvironments.podSchedulerName
field is removed.workspace.schedulerName
field is now unset.schedulerName of
default-scheduler`.output.mp4
What issues does this PR fix or reference?
eclipse-che/che#21803
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.