-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2344 support contract call nested option of case some none #2442
Merged
dsawali
merged 30 commits into
master
from
2344-support-contract-call-nested-option-of-case-Some_None
Apr 19, 2023
Merged
2344 support contract call nested option of case some none #2442
dsawali
merged 30 commits into
master
from
2344-support-contract-call-nested-option-of-case-Some_None
Apr 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-contract-call-nested-option-of-case-Some_None
…one' of github.com:ecadlabs/taquito into 2344-support-contract-call-nested-option-of-case-Some_None
…de(limitation) re #2344
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
A new deploy preview is available on Netlify at https://5e382c4--tezostaquito.netlify.app |
claudebarde
approved these changes
Apr 19, 2023
dsawali
approved these changes
Apr 19, 2023
dsawali
deleted the
2344-support-contract-call-nested-option-of-case-Some_None
branch
April 19, 2023 19:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Taquito.
closes #2344
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
In order to support case Some(None) when making contract calls in nested options like type (option (option nat)), we are introducing new semantic { Some: null } to
EncodeObject()
in @taquito/michelson-encoder.So user can make contract call with
.methodsObjects
in contractAPI and walletAPI.The old semantic still works but will look to deprecate them in the future.
Michelson type: option nat as Michelson Value: Some(1) can be called with 1 or [1] can now also be called with { Some: 1 } with methodObject.
And the corresponding
Execute()
in @taquito/michelson-encoder will return{ Some: '1' }
instead of previous1