Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2344 support contract call nested option of case some none #2442

Merged

Conversation

hui-an-yang
Copy link
Collaborator

@hui-an-yang hui-an-yang commented Apr 19, 2023

Thank you for your contribution to Taquito.

closes #2344

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

In order to support case Some(None) when making contract calls in nested options like type (option (option nat)), we are introducing new semantic { Some: null } to EncodeObject() in @taquito/michelson-encoder.
So user can make contract call with .methodsObjects in contractAPI and walletAPI.
The old semantic still works but will look to deprecate them in the future.
Michelson type: option nat as Michelson Value: Some(1) can be called with 1 or [1] can now also be called with { Some: 1 } with methodObject.
And the corresponding Execute() in @taquito/michelson-encoder will return { Some: '1' } instead of previous 1

hui-an-yang and others added 28 commits August 8, 2022 11:02
…t-contract-call-nested-option-of-case-Some_None
…one' of github.com:ecadlabs/taquito into 2344-support-contract-call-nested-option-of-case-Some_None
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit c5c8959
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/644011121c6f1f00089ed2bc
😎 Deploy Preview https://deploy-preview-2442--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

A new deploy preview is available on Netlify at https://5e382c4--tezostaquito.netlify.app

@hui-an-yang hui-an-yang requested a review from zainen April 19, 2023 17:07
@hui-an-yang hui-an-yang marked this pull request as ready for review April 19, 2023 17:07
@dsawali dsawali merged commit 5ba1e69 into master Apr 19, 2023
@dsawali dsawali deleted the 2344-support-contract-call-nested-option-of-case-Some_None branch April 19, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pass "Some None" to contract call
5 participants