Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to pass "Some None" to contract call #2344

Closed
claudebarde opened this issue Feb 16, 2023 · 2 comments · Fixed by #2442
Closed

Unable to pass "Some None" to contract call #2344

claudebarde opened this issue Feb 16, 2023 · 2 comments · Fixed by #2442
Assignees
@hui-an-yang
Labels
bug Something isn't working
Milestone
v16.2

Comments

@claudebarde
Copy link
Contributor

With the current implementation for contract call parameters, it is impossible to pass the value Some None to an entrypoint that requires a value of type option (option timestamp), for example.
Although this is an edge case, Taquito should provide a more intuitive way to pass options and nested options as contract call parameters, as the current way becomes inefficient or even broken with nested options.
@claudebarde claudebarde added the bug Something isn't working label Feb 16, 2023
@Innkst Innkst added this to the v16.1 milestone Feb 17, 2023
@hui-an-yang hui-an-yang self-assigned this Mar 16, 2023
@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Mar 29, 2023 •
edited
Loading

We are looking to support nested options contract call with methodsObject in our next release by introducing new semantics. And will deprecate the current semantic in the subsequent release for semantic consistency.
image

@claudebarde
Copy link
Contributor Author

The solutions in the subsequent release column look great :)

@Innkst Innkst modified the milestones: v16.1, v16.2 Apr 11, 2023
hui-an-yang added a commit that referenced this issue Apr 17, 2023
@hui-an-yang
fix: current work to support nested option
50be812 
re #2344
hui-an-yang added a commit that referenced this issue Apr 19, 2023
@hui-an-yang
feat: supporting nested option of some(none) in encodeObject and enco…
8a87d3d 
…de(limitation)

re #2344
hui-an-yang added a commit that referenced this issue Apr 19, 2023
@hui-an-yang
revert: implementation and test of nested options with encode (due to…
7c0aa75 
… limitation)

re #2344
@hui-an-yang hui-an-yang mentioned this issue Apr 19, 2023
Merged
9 tasks
hui-an-yang added a commit that referenced this issue Apr 19, 2023
@hui-an-yang
test: added integration tests and documentation
c5c8959 
re #2344
dsawali pushed a commit that referenced this issue Apr 19, 2023
@hui-an-yang @ac10n
2344 support contract call nested option of case some none (#2442)
5ba1e69 
* fix: current work to support nested option

re #2344

* simplify option encode

* feat: supporting nested option of some(none) in encodeObject and encode(limitation)

re #2344

* revert: implementation and test of nested options with encode (due to limitation)

re #2344

* test: added integration tests and documentation

re #2344

---------

Co-authored-by: Alireza Haghshenas <[email protected]>
@mweichert mweichert mentioned this issue Jul 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
bug Something isn't working
Projects
Taquito Dev
Status: Done
Milestone
v16.2
Development

Successfully merging a pull request may close this issue.

2344 support contract call nested option of case some none ecadlabs/taquito
3 participants
@claudebarde @Innkst @hui-an-yang