Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old semantic to make contract call of Michelson type Option with MethodObject #2533

Closed
hui-an-yang opened this issue Jun 16, 2023 · 1 comment
Closed

Deprecate old semantic to make contract call of Michelson type Option with MethodObject #2533

hui-an-yang opened this issue Jun 16, 2023 · 1 comment
Assignees
@hui-an-yang
Labels
2 Michelson-encoder
Milestone
v17.4

Comments

@hui-an-yang
Copy link
Collaborator

After pr #2442 that we introduce a new semantic to support Some(None) contract call with MethodObject, this is a following ticket to deprecate the old semantic

image
@Innkst Innkst changed the title deprecate old semantic to make contract call of Michelson type Option with MethodObject Deprecate old semantic to make contract call of Michelson type Option with MethodObject Jun 23, 2023
@Innkst Innkst added this to the v17.2 milestone Jun 23, 2023
@Innkst Innkst modified the milestones: v17.2, v17.3 Jul 13, 2023
@Innkst Innkst modified the milestones: v17.3, v18.1 Aug 1, 2023
@dsawali dsawali added the 2 label Aug 24, 2023
@Innkst Innkst modified the milestones: v18.1, v17.4 Oct 4, 2023
@hui-an-yang hui-an-yang self-assigned this Nov 7, 2023
@hui-an-yang
Copy link
Collaborator Author

have tried deprecated option token encodeObject() old semantic realizing the class Schema only has encode function but using encodeObject() under the hood. If deprecate old semantic on encodeObject() will cause regression on currently working .encode(). code for ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
2 Michelson-encoder
Projects
Taquito Dev
Status: Done
Milestone
v17.4
Development

No branches or pull requests
3 participants
@dsawali @Innkst @hui-an-yang