-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify that grafana autoupdates are deploying correctly #61
Comments
auto-update PR was merged #75 last week, but it looks like the workflow didn't run on the merge to main |
see also #87 |
manually deployed the update in #75 https://github.com/ebmdatalab/metrics/actions/runs/7399781682 |
as far as I can see, the GHA workflows in this repo (inc. the other tests) do not always run after the merge to main, and the GHA docs don't have much to say about it - I think they do if there's a merge commit but they don't if it applies cleanly. weirdly, I /thought/ there was a repo setting (something to the effect of "always re-run CI on main after merging a PR") but I just had a look & can't find anything like that here & now :/ I think we can easily widen the parameters in the |
hmm, maybe a weekly trigger would do the job |
@lucyb I've removed myself from this ticket, as I think it's your team's responsibility now - hope that's ok? (our team is still on deck-scrubbing, so I could potentially still pitch in if you need) |
Thanks @madwort . Yes, you're right that it's now a team rex responsibility. I'll try to take a look next week, although I may well pick your brains about it, if that's okay. |
There's an example here: https://github.com/ebmdatalab/metrics/actions/runs/7570488663 |
This isn't running on main after dependabot automerges it at the moment, so we're doing a manual check each week until we can figure it out. See #61
This isn't running on main after dependabot automerges it at the moment, so we're doing a manual check each week until we can figure it out. See #61
This isn't running on main after dependabot automerges it at the moment, so we're doing a manual check each week until we can figure it out. See #61
After some further investigation and no good solution in sight, I've moved us to doing manual deploys of grafana changes. |
797dc82
toca667dd
in /grafana #49 was correctly tested & auto-merged, but the deployment process did not run - in general the Grafana deployment job has been running on branches but not on the merge tomain
.The text was updated successfully, but these errors were encountered: