Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that grafana autoupdates are deploying correctly #61

Closed
madwort opened this issue Dec 1, 2023 · 9 comments · Fixed by #98
Closed

Verify that grafana autoupdates are deploying correctly #61

madwort opened this issue Dec 1, 2023 · 9 comments · Fixed by #98
Assignees

Comments

@madwort
Copy link
Contributor

madwort commented Dec 1, 2023

@madwort madwort self-assigned this Dec 1, 2023
@madwort
Copy link
Contributor Author

madwort commented Jan 3, 2024

auto-update PR was merged #75 last week, but it looks like the workflow didn't run on the merge to main

@madwort
Copy link
Contributor Author

madwort commented Jan 3, 2024

see also #87

@madwort
Copy link
Contributor Author

madwort commented Jan 3, 2024

manually deployed the update in #75 https://github.com/ebmdatalab/metrics/actions/runs/7399781682

@madwort
Copy link
Contributor Author

madwort commented Jan 4, 2024

as far as I can see, the GHA workflows in this repo (inc. the other tests) do not always run after the merge to main, and the GHA docs don't have much to say about it - I think they do if there's a merge commit but they don't if it applies cleanly. weirdly, I /thought/ there was a repo setting (something to the effect of "always re-run CI on main after merging a PR") but I just had a look & can't find anything like that here & now :/ I think we can easily widen the parameters in the on: section of the grafana deployment GHA to ensure that it runs, but then we're back to the previous issue that the deployment returns an error if there is no new version of grafana to deploy (which is most of the time).

@madwort
Copy link
Contributor Author

madwort commented Jan 4, 2024

hmm, maybe a weekly trigger would do the job

@lucyb lucyb self-assigned this Jan 8, 2024
@madwort madwort removed their assignment Jan 10, 2024
@madwort
Copy link
Contributor Author

madwort commented Jan 10, 2024

@lucyb I've removed myself from this ticket, as I think it's your team's responsibility now - hope that's ok?

(our team is still on deck-scrubbing, so I could potentially still pitch in if you need)

@lucyb
Copy link
Collaborator

lucyb commented Jan 10, 2024

Thanks @madwort . Yes, you're right that it's now a team rex responsibility. I'll try to take a look next week, although I may well pick your brains about it, if that's okay.

@lucyb
Copy link
Collaborator

lucyb commented Jan 19, 2024

lucyb added a commit that referenced this issue Jan 19, 2024
This isn't running on main after dependabot automerges it at the moment, so
we're doing a manual check each week until we can figure it out.

See #61
lucyb added a commit that referenced this issue Jan 19, 2024
This isn't running on main after dependabot automerges it at the moment, so
we're doing a manual check each week until we can figure it out.

See #61
lucyb added a commit that referenced this issue Jan 19, 2024
This isn't running on main after dependabot automerges it at the moment, so
we're doing a manual check each week until we can figure it out.

See #61
@lucyb lucyb closed this as completed in #98 Jan 19, 2024
@lucyb
Copy link
Collaborator

lucyb commented Jan 19, 2024

After some further investigation and no good solution in sight, I've moved us to doing manual deploys of grafana changes.
See #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants