Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the grafana workflow every week #98

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

lucyb
Copy link
Collaborator

@lucyb lucyb commented Jan 19, 2024

The grafana workflow isn't running on main after dependabot automerges it at the moment, so this change does a manual check each week until we can figure it out.

Fixes: #61

@lucyb lucyb force-pushed the deploy-grafana-specific-paths branch 3 times, most recently from 2dfe522 to a521b88 Compare January 19, 2024 15:39
@lucyb lucyb changed the title Restrict grafana deploys to specific file changes Run the grafana workflow every week Jan 19, 2024
Comment on lines 17 to 18
- 'grafana/**'
- '!grafana/README.md'
Copy link
Contributor

@madwort madwort Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I think I observed was that this workflow would run as expected when there were changes to 'grafana/*' in a branch that was not main (e.g. a PR). But would not run when the branch was merged to main when there was no merge commit - my suspicion is that there is no push event as when the commit merges cleanly it reuses the commit from the PR. This reduces duplication for running tests, but means that deploys don't happen when we want them to.

As such, my suspicion is that changing the wildcards here will not make a difference to the issue that we've been having. (but I'm happy to merge this if you think otherwise! the only way to be sure is to test!)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh of course, that would explain why it wasn't running on merge to main. I wasn't sure how the push/paths and schedule options would work together anyway, but having read your explanation I'll remove the push/paths and just have this run on a schedule in future.

Copy link
Contributor

@madwort madwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good workaround

@lucyb lucyb force-pushed the deploy-grafana-specific-paths branch from 14f113f to 9a73bb2 Compare January 19, 2024 15:58
This isn't running on main after dependabot automerges it at the moment, so
we're doing a manual check each week until we can figure it out.

See #61
@lucyb lucyb force-pushed the deploy-grafana-specific-paths branch from 9a73bb2 to 908ee45 Compare January 19, 2024 15:59
@lucyb lucyb enabled auto-merge January 19, 2024 16:00
@lucyb lucyb merged commit 83d8db2 into main Jan 19, 2024
7 checks passed
@lucyb lucyb deleted the deploy-grafana-specific-paths branch January 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that grafana autoupdates are deploying correctly
2 participants