Manually deploy updates to grafana #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madwort
reviewed
Jan 19, 2024
We are not able to determine when an update has been made by dependabot and then automatically deploy that change, due to `on: push:` not working with the `paths` option when there's a merge commit. We are also unable to easily check if grafana has been updated, which means most scheduled runs of the grafana workflow will fail. It means we're unlikely to spot real errors when they happen. Therefore, we are reverting to manual deployments for now.
lucyb
force-pushed
the
manually-deploy-grafana
branch
from
534b19b to
53ed624
Compare
madwort
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not able to determine when an update has been made by dependabot and then automatically deploy that change, due to
on: push:not working with thepathsoption when there's a merge commit.We are also unable to easily check if grafana has been updated, which means most scheduled runs of the grafana workflow will fail. It means we're unlikely to spot real errors when they happen.
Therefore, we are reverting to manual deployments for now.