Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(WorkItemFilters): Support multiple workItem filters #1429

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

brandonmikeska
Copy link
Contributor

@brandonmikeska brandonmikeska commented Oct 20, 2023

spread out the filters before pushing

Summary generated by Reviewpad on 24 Oct 23 02:11 UTC

This pull request fixes an issue with multiple workItem filters. The patch spreads out the filters before applying them.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

spread out the filters before pushing
@reviewpad reviewpad bot requested a review from azlam-abdulsalam October 20, 2023 21:48
@reviewpad
Copy link

reviewpad bot commented Oct 20, 2023

Thank you @brandonmikeska for this first contribution!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 20, 2023
@brandonmikeska brandonmikeska changed the title Fix multiple workItem filters fix(WorkItemFilters): Support multiple workItem filters Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a094576) 46.86% compared to head (92db58f) 46.86%.

❗ Current head 92db58f differs from pull request most recent head a267459. Consider uploading reports for the commit a267459 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1429   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          70       70           
  Lines        2665     2665           
  Branches      313      313           
=======================================
  Hits         1249     1249           
  Misses       1386     1386           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reviewpad
Copy link

reviewpad bot commented Oct 24, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Fix multiple workItem filters

spread out the filters before pushing' (801656d)

  • Unconventional commit detected: 'Merge branch 'main' into main' (3f0d89f)
  • Unconventional commit detected: 'Merge branch 'main' into main' (a267459)

⚠️ Warnings

  • Please link an issue to the pull request

@azlam-abdulsalam azlam-abdulsalam merged commit ede7266 into dxatscale:main Oct 24, 2023
2 checks passed
@azlam-abdulsalam azlam-abdulsalam linked an issue Oct 24, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work Item Filters Does not work with multiple filters
2 participants