Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(WorkItemFilters): Support multiple workItem filters #1429

Merged
merged 5 commits into from
Oct 24, 2023
Merged

fix(WorkItemFilters): Support multiple workItem filters #1429

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
801656d
Fix multiple workItem filters
brandonmikeska Oct 20, 2023
94cd075
fix: apply codefactor suggestion
azlam-abdulsalam Oct 24, 2023
2d762e9
fix(release): apply codefactor suggestion
azlam-abdulsalam Oct 24, 2023
3f0d89f
Merge branch 'main' into main
azlam-abdulsalam Oct 24, 2023
a267459
Merge branch 'main' into main
azlam-abdulsalam Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sfpowerscripts-cli/src/impl/release/ReleaseImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export default class ReleaseImpl {
for (const releaseDefinition of this.props.releaseDefinitions) {
releaseName = releaseName.concat(releaseDefinition.release, '-');
if (releaseDefinition.changelog) {
workitemFilters.push(releaseDefinition.changelog?.workItemFilters);
workitemFilters.push(...releaseDefinition?.changelog?.workItemFilters);
azlam-abdulsalam marked this conversation as resolved.
Show resolved Hide resolved
if (releaseDefinition.changelog.limit > limit) limit = releaseDefinition.changelog.limit;
workItemUrl = releaseDefinition.changelog.workItemUrl;
showAllArtifacts = releaseDefinition.changelog.showAllArtifacts;
Expand Down
2 changes: 1 addition & 1 deletion packages/sfpowerscripts-cli/tests/impl/changelog/WorkItemUpdater.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ describe('Given a WorkItemUpdater', () => {
const resourceDir: string = path.join(__dirname, 'resources');

it('should update latestRelease with work items', () => {
new WorkItemUpdater(latestRelease, ['NGV-[0-9]{3,4}']).update();
new WorkItemUpdater(latestRelease, ['NGV-[0-9]{3,4}', 'TEST-[0-9]{3,4}']).update();

expect(latestRelease).toEqual(
fs.readJSONSync(
Expand Down