fix(WorkItemFilters): Support multiple workItem filters (#1429)

* Fix multiple workItem filters spread out the filters before pushing * fix: apply codefactor suggestion * fix(release): apply codefactor suggestion --------- Co-authored-by: Azlam <[email protected]>
dxatscale · Oct 24, 2023 · ede7266 · ede7266
1 parent a094576
commit ede7266
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/sfpowerscripts-cli/src/impl/release/ReleaseImpl.ts b/packages/sfpowerscripts-cli/src/impl/release/ReleaseImpl.ts
@@ -79,7 +79,9 @@ export default class ReleaseImpl {
             for (const releaseDefinition of this.props.releaseDefinitions) {
                 releaseName = releaseName.concat(releaseDefinition.release, '-');
                 if (releaseDefinition.changelog) {
-                    workitemFilters.push(releaseDefinition.changelog?.workItemFilters);
+                    if(releaseDefinition.changelog.workItemFilters) {
+                       workitemFilters.push(...releaseDefinition.changelog?.workItemFilters);
+                    }
                     if (releaseDefinition.changelog.limit > limit) limit = releaseDefinition.changelog.limit;
                     workItemUrl = releaseDefinition.changelog.workItemUrl;
                     showAllArtifacts = releaseDefinition.changelog.showAllArtifacts;

diff --git a/packages/sfpowerscripts-cli/tests/impl/changelog/WorkItemUpdater.test.ts b/packages/sfpowerscripts-cli/tests/impl/changelog/WorkItemUpdater.test.ts
@@ -8,7 +8,7 @@ describe('Given a WorkItemUpdater', () => {
     const resourceDir: string = path.join(__dirname, 'resources');
 
     it('should update latestRelease with work items', () => {
-        new WorkItemUpdater(latestRelease, ['NGV-[0-9]{3,4}']).update();
+        new WorkItemUpdater(latestRelease, ['NGV-[0-9]{3,4}', 'TEST-[0-9]{3,4}']).update();
 
         expect(latestRelease).toEqual(
             fs.readJSONSync(