-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xSQLServerSetup: Fixes failover cluster bugs with shared disks #404
Conversation
Changed tests to be more dynamically and to find the bug in issue dsccommunity#401.
Now it can correctly determine the right cluster when only parameter InstallSQLDataDir is assigned a path (issue dsccommunity#401). Now the only mandatory path parameter is InstallSQLDataDir when installing Database Engine (issue dsccommunity#400). It now can handle mandatory parameters, and are not using wildcards to find the variables containing paths (issue dsccommunity#394).
Codecov Report
@@ Coverage Diff @@
## dev #404 +/- ##
====================================
+ Coverage 68% 68% +<1%
====================================
Files 31 31
Lines 3171 3183 +12
====================================
+ Hits 2180 2192 +12
Misses 991 991 Continue to review full report at Codecov.
|
Changed the logic of how the parameters are evaluated.
e6d2b66
to
e2ad23a
Compare
Reviewed 1 of 4 files at r1, 4 of 4 files at r2. README.md, line 857 at r2 (raw file):
Add full stop (.) to each sentence. README.md, line 860 at r2 (raw file):
Grammar wrong. 'Parameters mandatory when...' Comments from Reviewable |
Looks good to me. Waiting until tomorrow to merge if someone else wants to comment on anything. Reviewed 1 of 1 files at r3. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
Changes to xSQLServerSetup
This Pull Request (PR) fixes the following issues:
Fixes #394
Fixes #400
Fixes #401
This change is